Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Matillion SSL handling in the ingestion framework by preventing AttributeError when the selected Matillion auth variant does not include an sslConfig field (e.g., Matillion DPC vs. Matillion ETL), which can break test-connection flows.
Changes:
- Add
hasattr(..., "sslConfig")guards before accessingMatillionConnection.connection.sslConfiginSSLManager.setup_ssl. - Add the same guard in
check_ssl_and_initforMatillionConnectionbefore reading SSL config.
Code Review ✅ ApprovedFixes Matillion test connection with added unit tests to verify the functionality. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Contributor
🟡 Playwright Results — all passed (19 flaky)✅ 3599 passed · ❌ 0 failed · 🟡 19 flaky · ⏭️ 207 skipped
🟡 19 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
SumanMaharana
approved these changes
Apr 9, 2026
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
* fix matillion test connection * add unit tests
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
* fix matillion test connection * add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
hasattr()checks forsslConfigattribute in Matillion connection validation to prevent AttributeErrorThis will update automatically on new commits.