Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ingestion/src/metadata/utils/ssl_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ def _(self, connection):
matillion_connection = cast(MatillionConnection, connection)
if (
matillion_connection.connection
and hasattr(matillion_connection.connection, "sslConfig")
and matillion_connection.connection.sslConfig
):
if matillion_connection.connection.sslConfig.root.caCertificate:
Expand Down Expand Up @@ -351,7 +352,9 @@ def check_ssl_and_init(
@check_ssl_and_init.register(MatillionConnection)
def _(connection) -> Union[SSLManager, None]:
service_connection = cast(MatillionConnection, connection)
if service_connection.connection:
if service_connection.connection and hasattr(
service_connection.connection, "sslConfig"
):
Comment thread
ulixius9 marked this conversation as resolved.
ssl: Optional[
verifySSLConfig.SslConfig
] = service_connection.connection.sslConfig
Expand Down
98 changes: 98 additions & 0 deletions ingestion/tests/unit/test_ssl_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,104 @@ def test_init(self, get_connection, test_connection, setup_ssl):
)


class MatillionSSLManagerTest(TestCase):
"""
Tests for Matillion SSL Manager with DPC auth variant (no sslConfig)
"""

def test_check_ssl_and_init_dpc_connection_returns_none(self):
from metadata.generated.schema.entity.services.connections.pipeline.matillionConnection import (
MatillionConnection,
)
from metadata.utils.ssl_manager import check_ssl_and_init

connection = MatillionConnection(
connection={
"type": "MatillionDPC",
"clientId": "test-client",
"clientSecret": "test-secret",
"region": "us1",
}
)

result = check_ssl_and_init(connection)

self.assertIsNone(result)

def test_setup_ssl_dpc_connection_returns_connection_unchanged(self):
from metadata.generated.schema.entity.services.connections.pipeline.matillionConnection import (
MatillionConnection,
)

connection = MatillionConnection(
connection={
"type": "MatillionDPC",
"clientId": "test-client",
"clientSecret": "test-secret",
"region": "us1",
}
)

ssl_manager = SSLManager()
result = ssl_manager.setup_ssl(connection)

self.assertIs(result, connection)

def test_check_ssl_and_init_etl_connection_with_ssl(self):
from metadata.generated.schema.entity.services.connections.pipeline.matillionConnection import (
MatillionConnection,
)
from metadata.utils.ssl_manager import check_ssl_and_init

connection = MatillionConnection(
connection={
"type": "MatillionETL",
"hostPort": "https://matillion.example.com",
"username": "admin",
"password": "password",
"sslConfig": {"caCertificate": "caCertificateData"},
}
)

ssl_manager = check_ssl_and_init(connection)

self.assertIsNotNone(ssl_manager)
self.assertIsNotNone(ssl_manager.ca_file_path)

ssl_manager.cleanup_temp_files()

def test_check_ssl_and_init_etl_connection_without_ssl(self):
from metadata.generated.schema.entity.services.connections.pipeline.matillionConnection import (
MatillionConnection,
)
from metadata.utils.ssl_manager import check_ssl_and_init

connection = MatillionConnection(
connection={
"type": "MatillionETL",
"hostPort": "https://matillion.example.com",
"username": "admin",
"password": "password",
}
)

result = check_ssl_and_init(connection)

self.assertIsNone(result)

def test_check_ssl_and_init_no_connection_returns_none(self):
from metadata.generated.schema.entity.services.connections.pipeline.matillionConnection import (
MatillionConnection,
)
from metadata.utils.ssl_manager import check_ssl_and_init

connection = MatillionConnection()

result = check_ssl_and_init(connection)

self.assertIsNone(result)


class MssqlSSLManagerTest(TestCase):
"""
Tests for MSSQL SSL Manager functionality
Expand Down
Loading