Skip to content

fix matillion test connection #27122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulixius9 merged 2 commits into from
Apr 10, 2026
Merged

fix matillion test connection #27122

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83da945
fix matillion test connection
ulixius9 Apr 7, 2026
d83b5d6
add unit tests
ulixius9 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ingestion/src/metadata/utils/ssl_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ def _(self, connection):
matillion_connection = cast(MatillionConnection, connection)
if (
matillion_connection.connection
and hasattr(matillion_connection.connection, "sslConfig")
and matillion_connection.connection.sslConfig
):
if matillion_connection.connection.sslConfig.root.caCertificate:
Expand Down Expand Up @@ -351,7 +352,9 @@ def check_ssl_and_init(
@check_ssl_and_init.register(MatillionConnection)
def _(connection) -> Union[SSLManager, None]:
service_connection = cast(MatillionConnection, connection)
if service_connection.connection:
if service_connection.connection and hasattr(
service_connection.connection, "sslConfig"
):
Comment thread
ulixius9 marked this conversation as resolved.
ssl: Optional[
verifySSLConfig.SslConfig
] = service_connection.connection.sslConfig
Expand Down
Loading