feat: Improve buffer lifecycle handling in useBuffer hook#12
Open
feat: Improve buffer lifecycle handling in useBuffer hook#12
useBuffer hook#12Conversation
iwoplaza
reviewed
Jul 29, 2025
Collaborator
iwoplaza
left a comment
There was a problem hiding this comment.
Awesome! One question, could you test this out in React.StrictMode? I am wondering if the interplay between useMemo and the cleanup in useEffect could cause the first buffer to be destroyed even before it's first use.
Collaborator
Author
|
@iwoplaza You were right, my implementation caused that the first buffer was destroyed on first use. This ref based implementation wasn't for no reason 😅. I tried to implement this hook without using it, but with no success. I will revert to previous implementation and replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
useBufferhook to simplify its implementation and improve performance.useRef, replacing it with a direct management of the buffer lifecycle.useLayoutEffectwithuseEffectfor writing values to the buffer.Test
To test the new implementation, I added proper logs in
useBufferhook and labeled buffers fromConfettiVizcomponent to effectively trace the buffer lifecycle and renders. As it is seen in testing, the buffer is successfully reallocated on schema change and new data is successfully written onuseEffectwithout performance impact.Old implementation
old-implementation.mov
New implementation
new-implementation.mov