Skip to content

Link to fixed tag for source links #16883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkniewallner wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Link to fixed tag for source links #16883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/compile-test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ fn ui_cargo_toml_metadata() {
struct Renderer<'a> {
count: usize,
lints: &'a Vec<LintMetadata>,
git_ref: String,
}

impl Renderer<'_> {
Expand Down Expand Up @@ -522,6 +523,7 @@ impl DiagnosticCollector {
Renderer {
count: LINTS.len(),
lints: &metadata,
git_ref: env::var("TAG_NAME").unwrap_or("master".to_string()),
}
.render()
.unwrap(),
Expand Down
2 changes: 1 addition & 1 deletion util/gh-pages/index_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ <h2 class="lint-title"> {# #}

{# Jump to source #}
{% if let Some(id_location) = lint.id_location %}
<a href="https://github.com/rust-lang/rust-clippy/blob/master/{{id_location}}">View Source</a>
<a href="https://github.com/rust-lang/rust-clippy/blob/{{git_ref}}/{{id_location}}">View Source</a>
{% endif %}
</div> {# #}
</div> {# #}
Expand Down
Loading