Skip to content

Link to fixed tag for source links#16883

Open
mkniewallner wants to merge 1 commit intorust-lang:masterfrom
mkniewallner:issue16882
Open

Link to fixed tag for source links#16883
mkniewallner wants to merge 1 commit intorust-lang:masterfrom
mkniewallner:issue16882

Conversation

@mkniewallner
Copy link
Copy Markdown

@mkniewallner mkniewallner commented Apr 18, 2026

Closes #16882.

Make the "View Source" links point to a fixed tag version when TAG_NAME env var is set (which is the case in the release workflow) instead of always linking to master.

Test plan

Tested locally with both:

TAG_NAME=rust-1.95.0 cargo collect-metadata
cargo collect-metadata

Links point to https://github.com/rust-lang/rust-clippy/blob/rust-1.95.0/... in the first case, and https://github.com/rust-lang/rust-clippy/blob/master/... in the second one.

changelog: none

@mkniewallner mkniewallner marked this pull request as ready for review April 18, 2026 12:43
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 18, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 18, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"View Source" links on website always link to dynamic master branch

3 participants