Add Flow Refueling Location Model (FRLM)#487
Conversation
fengzixin0617
commented
Jun 3, 2025
- Add FRLM class and example notebook
- With exact and greedy solver options
- Combined capacited FRLM and basic FRLM
ljwolf
left a comment
There was a problem hiding this comment.
Overall, great first pass! We need some more documentation throughout, and we need to consider this in light of the naming conventions and API style of the other problems.
See the comments across the PR for advice.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=======================================
- Coverage 77.8% 76.9% -0.9%
=======================================
Files 27 29 +2
Lines 2638 3700 +1062
=======================================
+ Hits 2053 2846 +793
- Misses 585 854 +269
🚀 New features to boost your workflow:
|
gegen07
left a comment
There was a problem hiding this comment.
Great work! Some comments about the code. I have not reviewed the whole file but I think it is good for this round. :)
gegen07
left a comment
There was a problem hiding this comment.
Wow! This is brilliant.
Just minor comments. In summary, the code is much cleaner and organized. Great work!!!!!!
3d17a6d to
1c38769
Compare
cb4cd8b to
4f80a3f
Compare
|
Yes, I'm also fine to ship 😄 super work @fengzixin0617 |