Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
- Coverage 77.8% 70.2% -7.6%
=======================================
Files 27 32 +5
Lines 2638 4054 +1416
=======================================
+ Hits 2053 2846 +793
- Misses 585 1208 +623
🚀 New features to boost your workflow:
|
spopt.route v1.0
There was a problem hiding this comment.
A couple thoughts from the notebook before getting into code itself
- notebook refers to
spopt.Route- Is that meant to be referring to
route.heuristic.LastMile? - Should we keep
LastMileor consider renaming toRoute? - Or other ideas?
- Is that meant to be referring to
- need to remove hardcoded pathing --
dylan/projects/gsoc2025
There was a problem hiding this comment.
- need to remove hardcoded pathing -- dylan/projects/gsoc2025
Let me know once you've updated the pathing
- notebook refers to spopt.Route
- Is that meant to be referring to route.heuristic.LastMile?
- Should we keep LastMile or consider renaming to Route?
- Or other ideas?
What are your thought here?
There was a problem hiding this comment.
A couple thoughts from the notebook before getting into code itself
notebook refers to
spopt.Route
- Is that meant to be referring to
route.heuristic.LastMile?- Should we keep
LastMileor consider renaming toRoute?- Or other ideas?
need to remove hardcoded pathing --
dylan/projects/gsoc2025
Sorry I did not see this back when you originally posted it.
- need to remove hardcoded pathing --
dylan/projects/gsoc2025
I have removed the hardcoded pathing issue and will push it up momentarily.
- Should we keep
LastMileor consider renaming toRoute?
I would posit that Route is a module of spopt, where LastMile is the first of potentially many solver classes within Route, though I'd defer to the lead maintainers about this.
There was a problem hiding this comment.
I would posit that
Routeis a module ofspopt, whereLastMileis the first of potentially many solver classes withinRoute, though I'd defer to the lead maintainers about this.
So that would be the route.py module, but that seems OK from my view point.
There was a problem hiding this comment.
I have removed the hardcoded pathing issue and will push it up momentarily.
Ping me once you have pushed up those removals.
There was a problem hiding this comment.
I pushed the notebook change up to my PR with the test suite, merging that would propagate it here as well @ljwolf. Let me know if you'd prefer it into pysal:main separately
There was a problem hiding this comment.
I think we'd like that to propagate here as well. But we'll wait for @ljwolf's direction.
|
We should definitely try to get this merged. I think it'd be sufficient to run through the precommit hook and address @jGaboardi's comments, but I'll need to re-review for the final merge. |
|
@ljwolf – yep this def fell under the radar for me. Once my comments above are taken care of, please ping me again for more review. |
|
Hi both - I don't think we have an update of spopt in this Jan Pysal release (correct me if I am wrong)? Will we wait until the routing engine is reviewed and finished, then both of the GSoC results will be merged into the next release? |
Hi, @qszhao ! The latest We cut a release whenever we like, it really just depends if we want both GSoC contributions in the same release or not. |
Thanks @jGaboardi! I don't see FRLM has been included in 0.7.0, and that's why I ask. I guess that will be out in the next release anyway? |
Correct.
Absolutely. |
|
xref - #507 |
This adds the initial routing engine explained in #464.