feat: Add ability to allowDiskUse

[stewones]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue

Issue Description

this is so we can pass a boolean to ParseQuery

i.e.

const GameScore = Parse.Object.extend("GameScore");
const query = new Parse.Query(GameScore);

query.allowDiskUse(true); // <----------

query.equalTo("playerName", "Dan Stemkoski");
const results = await query.find();

Approach

TODOs before merging

• Add tests
• Add changes to documentation (guides, repository pages, in-code descriptions)

[parse-github-assistant]

I will reformat the title to use the proper commit message syntax.

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

[mtrezza]

query.allowDiskUse(true); // <----------

I'm not sure about this syntax. This is not a Parse.Query property but a meta property of the query, actually it's a database driver parameter. Such meta properties are usually set in the options, like: await query.find({ useMasterKey: true, allowDiskUse: true });

[stewones]

yeah I just followed what readPreferences does, actually was planning to add support for both ways

[stewones]

see this line @mtrezza

Parse-SDK-JS/src/ParseQuery.js

Line 1959 in ad10705

readPreference(

[mtrezza]

Right, I guess there wasn't a clear strategy so far how to add options. Allowing to set as Parse.Query property and meta property is a code duplication. Let's decide for one way or the other. What do you think makes more sense?

One strategy to decide is to look at what the option does:

• An option that influences the query response (i.e. response content) should be a Parse.Query property
• An option that doesn't influence the query response but only changes how a query is executed should be a meta option

[stewones]

makes sense @mtrezza
so we should go as a meta option

[mtrezza]

Alright sounds good

[mtrezza]

What's the state of this PR? Do you plan to continue with it or should we close it for now?

[stewones]

Yeah you can close this and any other PR of mine. Lost interest in Parse unfortunately since it's blocking me more than helping. And I understand that, not every tool is the right choice for every need.

Thanks.

[mtrezza]

Sorry to hear that and thanks for the heads up. If you have any other feedback, please feel free to share. All the best!