Skip to content

DBX-6700 Query-based compiler & Multifile support#870

Open
huydo862003 wants to merge 223 commits intomasterfrom
feat/module-system-3
Open

DBX-6700 Query-based compiler & Multifile support#870
huydo862003 wants to merge 223 commits intomasterfrom
feat/module-system-3

Conversation

@huydo862003
Copy link
Copy Markdown
Contributor

@huydo862003 huydo862003 commented Apr 14, 2026

Summary

Suggested review order

  1. Review the TDD for query-based compiler: https://www.notion.so/holistics/TDD-94-Query-based-compiler-Overview-of-the-compiler-architecture-345f89dc7e4980e88bc9fd6d140c1d8b
  2. Check the files for Filepath, SyntaxNode, NodeSymbol and the internable types Internable.
  3. Check the compiler.ts file:
    a. Check how the local cache & the global cache are setup (localQuery and globalQuery methods).
    b. Check what queries we have: https://www.notion.so/holistics/TDD-94-Query-based-compiler-Overview-of-the-compiler-architecture-345f89dc7e4980e88bc9fd6d140c1d8b?v=b4c7e791a9664e779faf139f7f7bda40&source=copy_link#345f89dc7e49804f8f0edca6282a32c8
  4. Check the overall flow of the compiler: Compiler query -> Interning the args -> Check query cache -> Dispatch to query module (chain-of-responsibility) -> Cache the result -> return.
  5. Check lexer, parser.
  6. Check the local_modules for validator (do not care about multifile support yet).
  7. Check the global_modules for binder and interpreter (do not care about multifile support yet).
  8. Check the multifile support: check the local modules, global modules for use.

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Lint Checks Passed
  • Unit Tests Passed
  • Coverage Tests Passed
  • Integration Tests Passed
  • Code Review

@huydo862003 huydo862003 requested review from NQPhuc, huyphung1602, nguyenalter and xuantho573 and removed request for huyphung1602 and nguyenalter April 20, 2026 03:42
# Conflicts:
#	dbml-playground/package.json
#	packages/dbml-core/types/index.d.ts
#	packages/dbml-parse/__tests__/examples/compiler/syncDiagramView.test.ts
#	packages/dbml-parse/src/compiler/queries/transform/syncDiagramView.ts
#	packages/dbml-parse/src/core/interpreter/interpreter.ts
@huydo862003 huydo862003 force-pushed the feat/module-system-3 branch from f8a23ed to 5907cf7 Compare April 20, 2026 08:58
@huydo862003 huydo862003 force-pushed the feat/module-system-3 branch from dc60fa9 to ec99c50 Compare April 20, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant