refactor: completion item service option

Author: huydo862003

packages/dbml-parse/src/compiler/index.ts

@@ -374,26 +374,31 @@ export default class Compiler {
     scopeKind: this.localQuery(containerScopeKind),
   };
 
-  async initMonacoServices () {
+  async initMonacoServices (options?: {
+    autocompletion?: {
+      triggerCharacters?: string[];
+    };
+  }) {
+    const triggerCharacters = options?.autocompletion?.triggerCharacters ?? [
+      '.',
+      ',',
+      '[',
+      '(',
+      ':',
+      '>',
+      '<',
+      '-',
+      '~',
+      '\'',
+      '"',
+      '/',
+      ' ',
+    ];
+
     return {
       definitionProvider: new DBMLDefinitionProvider(this),
       referenceProvider: new DBMLReferencesProvider(this),
-      // Trigger completion on these characters
-      autocompletionProvider: new DBMLCompletionItemProvider(this, [
-        '.',
-        ',',
-        '[',
-        '(',
-        ':',
-        '>',
-        '<',
-        '-',
-        '~',
-        '\'',
-        '"',
-        '/',
-        ' ',
-      ]),
+      autocompletionProvider: new DBMLCompletionItemProvider(this, { triggerCharacters }),
       diagnosticsProvider: new DBMLDiagnosticsProvider(this),
     };
   }

packages/dbml-parse/src/services/suggestions/provider.ts

@@ -52,7 +52,6 @@ import {
   isOffsetWithinSpan,
 } from '@/core/utils/span';
 import {
-  buildCrossFileCompletionItem,
   collectCrossFileSuggestions,
 } from '@/services/suggestions/crossFile';
 import {
@@ -85,46 +84,18 @@ import {
   getOffsetFromMonacoPosition,
 } from '@/services/utils';
 
+export interface DBMLCompletionItemProviderOptions {
+  triggerCharacters?: string[];
+}
+
 export default class DBMLCompletionItemProvider implements CompletionItemProvider {
   private compiler: Compiler;
 
   triggerCharacters: string[];
 
-  constructor (compiler: Compiler, triggerCharacters: string[] = []) {
+  constructor (compiler: Compiler, options: DBMLCompletionItemProviderOptions = {}) {
     this.compiler = compiler;
-    this.triggerCharacters = triggerCharacters;
-  }
-
-  // Cross-file suggestion surfaces symbols from sibling project files at
-  // global-scope lookup points. Implementation in ./crossFile.ts — these
-  // thin wrappers keep the public provider surface stable for existing
-  // call sites that want a CompletionList.
-  suggestCrossFileSymbols (
-    acceptedKinds: SymbolKind[],
-    currentFilepath: Filepath,
-    _currentFileContent: string,
-  ): CompletionList {
-    return {
-      suggestions: collectCrossFileSuggestions(this.compiler, acceptedKinds, currentFilepath),
-    };
-  }
-
-  createCrossFileCompletionItem (
-    symbolName: string,
-    symbolKind: SymbolKind,
-    _fileHint: string,
-    sourceFilepath: Filepath,
-    currentFilepath: Filepath,
-    currentFileContent: string,
-  ): CompletionItem {
-    return buildCrossFileCompletionItem(
-      this.compiler,
-      symbolName,
-      symbolKind,
-      sourceFilepath,
-      currentFilepath,
-      currentFileContent,
-    );
+    this.triggerCharacters = options.triggerCharacters ?? [];
   }
 
   provideCompletionItems (model: TextModel, position: Position): CompletionList {