Skip to content

fix: fix typos and grammar in comments of core/datasetController #12241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lamhn9999 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

fix: fix typos and grammar in comments of core/datasetController #12241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/core/core.datasetController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export default class DatasetController {
static datasetElementType = null;

/**
* Element type used to generate a meta data (e.g. Chart.element.PointElement).
* Element type used to generate a metadata (e.g. Chart.element.PointElement).
*/
static dataElementType = null;

Expand Down Expand Up @@ -420,7 +420,7 @@ export default class DatasetController {
meta.stack = dataset.stack;
}

// Re-sync meta data in case the user replaced the data array or if we missed
// Re-sync metadata in case the user replaced the data array or if we missed
// any updates and so make sure that we handle number of datapoints changing.
this._resyncElements(resetNewElements);

Expand Down Expand Up @@ -642,12 +642,12 @@ export default class DatasetController {
}
this.updateRangeFromParsed(range, scale, parsed, stack);
if (sorted) {
// if the data is sorted, we don't need to check further from this end of array
// if the data is sorted, we don't need to check further from this end of the array
break;
}
}
if (sorted) {
// in the sorted case, find first non-skipped value from other end of array
// in the sorted case, find the first non-skipped value from the other end of the array
for (i = ilen - 1; i >= 0; --i) {
if (_skip()) {
continue;
Expand Down Expand Up @@ -822,7 +822,7 @@ export default class DatasetController {

if (values.$shared) {
// `$shared` indicates this set of options can be shared between multiple elements.
// Sharing is used to reduce number of properties to change during animation.
// Sharing is used to reduce the number of properties to change during animation.
values.$shared = sharing;

// We cache options by `mode`, which can be 'active' for example. This enables us
Expand Down