Skip to content

Verify image builds with -PNonRESTCatalogs=HIVE,HADOOP #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nandorKollar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Verify image builds with -PNonRESTCatalogs=HIVE,HADOOP #4232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ jobs:
uses: ./.github/actions/ci-incr-build-cache-prepare
- name: Image build
env: *gradle_env_vars
run: ./gradlew :polaris-server:assemble -Dquarkus.container-image.build=true
run: ./gradlew :polaris-server:assemble -PNonRESTCatalogs=HIVE,HADOOP -Dquarkus.container-image.build=true
Copy link
Copy Markdown
Member

@jbonofre jbonofre Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea. Let's see if we have stable build/test here.

Copy link
Copy Markdown
Member

@snazy snazy Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's then no longer what we publish as our official images.
WDYT of having a separate job instead of changing the existing one?

Copy link
Copy Markdown
Contributor Author

@nandorKollar nandorKollar Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that if you think that's better. Or we can even have an extra step in build-checks job, which would execute ./gradlew :polaris-server:assemble :polaris-server:quarkusAppPartsBuild -PNonRESTCatalogs=HIVE,HADOOP.

Copy link
Copy Markdown
Contributor

@flyrain flyrain Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will need a check at build time instead of publishing. If the publish CI reuse this one, we need to separate it out.

- name: Save image to tar
run: |
docker save apache/polaris:latest | zstd -T0 > polaris-image.tar.zst
Expand Down
Loading