Verify image builds with -PNonRESTCatalogs=HIVE,HADOOP#4232
Verify image builds with -PNonRESTCatalogs=HIVE,HADOOP#4232nandorKollar wants to merge 1 commit intoapache:mainfrom
Conversation
|
Alternatively, we can add an extra step to |
| - name: Image build | ||
| env: *gradle_env_vars | ||
| run: ./gradlew :polaris-server:assemble -Dquarkus.container-image.build=true | ||
| run: ./gradlew :polaris-server:assemble -PNonRESTCatalogs=HIVE,HADOOP -Dquarkus.container-image.build=true |
There was a problem hiding this comment.
It's a good idea. Let's see if we have stable build/test here.
There was a problem hiding this comment.
Hm, that's then no longer what we publish as our official images.
WDYT of having a separate job instead of changing the existing one?
There was a problem hiding this comment.
We can do that if you think that's better. Or we can even have an extra step in build-checks job, which would execute ./gradlew :polaris-server:assemble :polaris-server:quarkusAppPartsBuild -PNonRESTCatalogs=HIVE,HADOOP.
There was a problem hiding this comment.
I think we will need a check at build time instead of publishing. If the publish CI reuse this one, we need to separate it out.
This PR adds
-PNonRESTCatalogs=HIVE,HADOOPparameters to thedocker-image-buildCI job to verify, that Docker image build succeeds with Hive and Hadoop federated catalog extensions. We can avoid merging PRs, which can break the build with these extensions.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)