Skip to content

Verify image builds with -PNonRESTCatalogs=HIVE,HADOOP#4232

Open
nandorKollar wants to merge 1 commit intoapache:mainfrom
nandorKollar:verify_image_build_with_extensions
Open

Verify image builds with -PNonRESTCatalogs=HIVE,HADOOP#4232
nandorKollar wants to merge 1 commit intoapache:mainfrom
nandorKollar:verify_image_build_with_extensions

Conversation

@nandorKollar
Copy link
Copy Markdown
Contributor

@nandorKollar nandorKollar commented Apr 17, 2026

This PR adds -PNonRESTCatalogs=HIVE,HADOOP parameters to the docker-image-build CI job to verify, that Docker image build succeeds with Hive and Hadoop federated catalog extensions. We can avoid merging PRs, which can break the build with these extensions.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

@nandorKollar
Copy link
Copy Markdown
Contributor Author

Alternatively, we can add an extra step to build-checks, which would build Polaris server with each extension enabled.

Comment thread .github/workflows/ci.yml
- name: Image build
env: *gradle_env_vars
run: ./gradlew :polaris-server:assemble -Dquarkus.container-image.build=true
run: ./gradlew :polaris-server:assemble -PNonRESTCatalogs=HIVE,HADOOP -Dquarkus.container-image.build=true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea. Let's see if we have stable build/test here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's then no longer what we publish as our official images.
WDYT of having a separate job instead of changing the existing one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that if you think that's better. Or we can even have an extra step in build-checks job, which would execute ./gradlew :polaris-server:assemble :polaris-server:quarkusAppPartsBuild -PNonRESTCatalogs=HIVE,HADOOP.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will need a check at build time instead of publishing. If the publish CI reuse this one, we need to separate it out.

@github-project-automation github-project-automation Bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants