feat(retry): record more fields in the retry interceptor#7406
Open
dentiny wants to merge 2 commits intoapache:mainfrom
Open
feat(retry): record more fields in the retry interceptor#7406dentiny wants to merge 2 commits intoapache:mainfrom
dentiny wants to merge 2 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Hi team, in production I need to collect retry-related metrics, like retry attempt count, retry errors, retry operations, etc.
Currently the best way to leverage existing retry layer out-of-box is via the interceptor, which it still misses a few fields.
I raise a related feature request here: #7312, but requires more change.
What changes are included in this PR?
This PR adds more fields to the retry interceptor and wrap all of them into
RetryEventstructAre there any user-facing changes?
Yes, this is an API change if users are creating their own interceptor, but it's an easy change to migrate to
RetryEvent.AI Usage Statement
I used opus 4.6 to make code change, with me doing code review.