Skip to content

[backend] try catch during migration to handle corrupted notes (#15493) #15615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeremyCloarec merged 1 commit into from
Apr 21, 2026
Merged

[backend] try catch during migration to handle corrupted notes (#15493) #15615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions opencti-platform/opencti-graphql/src/migrations/1776164753048-note_standard_id_abstract.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,21 @@ export const up = async (next) => {
const callback = (notes) => {
const op = notes
.map((note) => {
const newId = generateStandardId(note.entity_type, note);
if (newId === note.standard_id) {
try {
const newId = generateStandardId(note.entity_type, note);
if (newId === note.standard_id) {
return [];
}
const previousStixIds = note.x_opencti_stix_ids ?? [];
const updatedStixIds = R.uniq([...previousStixIds, note.standard_id]);
return [
{ update: { _index: note._index, _id: note._id } },
{ doc: { standard_id: newId, x_opencti_stix_ids: updatedStixIds } },
];
} catch (err) {
logApp.warn('[OPENCTI] Error during note rewrite, skipping', { err, note });
return [];
}
const previousStixIds = note.x_opencti_stix_ids ?? [];
const updatedStixIds = R.uniq([...previousStixIds, note.standard_id]);
return [
{ update: { _index: note._index, _id: note._id } },
{ doc: { standard_id: newId, x_opencti_stix_ids: updatedStixIds } },
];
})
.flat();
pushAll(bulkOperations, op);
Expand Down
Loading