Skip to content

[backend] try catch during migration to handle corrupted notes (#15493)#15615

Merged
JeremyCloarec merged 1 commit intomasterfrom
issue/15493migrationFix
Apr 21, 2026
Merged

[backend] try catch during migration to handle corrupted notes (#15493)#15615
JeremyCloarec merged 1 commit intomasterfrom
issue/15493migrationFix

Conversation

@JeremyCloarec
Copy link
Copy Markdown
Contributor

@JeremyCloarec JeremyCloarec commented Apr 21, 2026

Proposed changes

  • try catch during migration to handle corrupted notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions Bot added the filigran team use to identify PR from the Filigran team label Apr 21, 2026
@JeremyCloarec JeremyCloarec marked this pull request as ready for review April 21, 2026 13:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.61%. Comparing base (2ff2889) to head (662fc45).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15615   +/-   ##
=======================================
  Coverage   33.61%   33.61%           
=======================================
  Files        3189     3189           
  Lines      216746   216746           
  Branches    39951    39952    +1     
=======================================
  Hits        72856    72856           
  Misses     143890   143890           
Flag Coverage Δ
opencti-client-python 45.60% <ø> (ø)
opencti-front 2.94% <ø> (ø)
opencti-graphql 70.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested locally it's running fine.

@JeremyCloarec JeremyCloarec merged commit b187b0c into master Apr 21, 2026
52 of 53 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/15493migrationFix branch April 21, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notes with identical content and created date collide due to missing attribute_abstract in standard_id

2 participants