configmgr extract: no new line for the last array item#525
Open
Martin-Zeithaml wants to merge 4 commits intov3.x/stagingfrom
Open
configmgr extract: no new line for the last array item#525Martin-Zeithaml wants to merge 4 commits intov3.x/stagingfrom
configmgr extract: no new line for the last array item#525Martin-Zeithaml wants to merge 4 commits intov3.x/stagingfrom
Conversation
Signed-off-by: Martin Zeithaml <Martin.Zeithaml@broadcom.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




configmgr extractfeature is printing new line character for each key found. But for the array, it prints new line char twice, which is might be confusing for arrays with empty strings.Without fix
There are 2 empty lines at the end, which might be considered as 2 empty items:
With fix
Empty item, not last and with fix