Open
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
|
timgerstel
reviewed
Apr 17, 2026
| // --- Ref-value hover --- | ||
| const refName = getHoveredRefName(lineText, position.column); | ||
| if (refName) { | ||
| const allLines = model.getValue().split('\n'); |
Contributor
There was a problem hiding this comment.
model.getValue().split('\n') is called for every hover, ctrl+click, and AT-TLS auto completion which might be a performance concern of someone has a giant monolithic AT-TLS policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed changes
This PR adds a Monaco/Monarch language mode for IBM z/OS AT-TLS (Application Transparent
Transport Layer Security) Policy Agent files. When a plaintext file contains a
TTLSRuledeclaration at the start of a line, the editor automatically detects and activates the
attlslanguage mode.Key user-facing improvements:
attls-dark).TTLSConnectionActionRef) shows the full declaration block of the referenced item inline, eliminating the need to scroll or search manually.TTLSConnectionAction,RemotePortRangeRef,HandshakeRole,TLSv1.2) shows a brief description of that keyword's purpose and valid values.TTLSRuleare detected regardless of filename or extension, making the feature work for unnamed datasets and files with arbitrary names.Type of change
PR Checklist
Files changed
webClient/src/app/editor/code-editor/monaco/hiliters/attls.tsATTLS_KEYWORD_DOCSmap (64 keywords).webClient/src/app/editor/code-editor/monaco/monaco.config.tsattlslanguage,attls-darktheme, Monarch provider, and hover provider.webClient/src/app/shared/editor-control/editor-control.service.tsattls-darktheme case tosetThemeForLanguage; adds content-based language detection pass ingetRecommendedHighlightingModesForBuffer.CHANGELOG.md3.5.0.Testing
attlsin the editor status bar (no extension or filename pattern should be required).*Refkeys are purple, reference values are underlined gold, comments are green, braces are blue.TTLSGroupActionRef,TTLSEnvironmentActionRef,TTLSConnectionActionRef,LocalPortRangeRef, etc. line — the full declaration block for the referenced item should appear in the hover popup.ALL,On,Off, bare numbers) — no popup should appear.HandshakeRole,TLSv1.2,CertificateLabel) — a brief description should appear.Further comments
The content-based detection mechanism introduced in
getRecommendedHighlightingModesForBufferis generic: any future language can opt in by setting
contentDetect: truealongside afirstLineregex in its language registration object. This avoids the need for changes tothe detection service for each new language that cannot be identified by filename alone.
The hover provider is structured with two priority levels so that ref-value popups (which
show live file content) always take precedence over generic keyword descriptions. If a
referenced item is not declared in the current file the keyword description is shown as a
fallback, which is still more useful than silence.