Fix O(N) global scan in artifact-version delete#4686
Open
joaquinhuigomez wants to merge 1 commit intozenml-io:developfrom
Open
Fix O(N) global scan in artifact-version delete#4686joaquinhuigomez wants to merge 1 commit intozenml-io:developfrom
joaquinhuigomez wants to merge 1 commit intozenml-io:developfrom
Conversation
Replace depaginate(list_artifact_versions, only_unused=True) with a targeted query filtering by the specific artifact version ID, avoiding a full scan of all unused versions on every delete call.
|
|
Contributor
|
@joaquinhuigomez thank you for the PR! Can you please sign the CLA? We will take a look as soon as possible. |
schustmi
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depaginate(list_artifact_versions, only_unused=True)membership check in_delete_artifact_versionwith a targeted query that filters by the specific artifact version ID (id=artifact_version.id, only_unused=True, size=1)only_unuseddepagination per delete #4684 for profiling data showing ~41s per delete reduced to ~0.6s)Test plan
Client.delete_artifact_version()still raisesValueErrorfor in-use artifact versionsFixes #4684