Update code to work with version 3.3.4 of Bosch driver#2
Open
kumekay wants to merge 1 commit intoyanbe:masterfrom
Open
Update code to work with version 3.3.4 of Bosch driver#2kumekay wants to merge 1 commit intoyanbe:masterfrom
kumekay wants to merge 1 commit intoyanbe:masterfrom
Conversation
|
I got the your Pull #2 to work with the latest Bosch drivers (Master Branch as of today) by changing the I2C speed to 100000 from 40000. I also changed the return type of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably I shouldn't make pull request, because this updated code doesn't work perfectly - it works as expected only with very low i2c clock speeds, like 40000.
If master_clk is ~ 100000 only pressure and humidity are sent by sensor,
if master_clk is 400000 or more - only humidity is sent (as non zero value).
I spent some time, but didn't find root of this issue, but it would be great, if you can help. Expect of this problem this commit fully supports lastest Bosch driver (v3.3.4)