Skip to content

[libyaml]: document end fixes (9afa10a, fa1293a & 3694a4a)#103

Draft
inteon wants to merge 3 commits intoyaml:mainfrom
inteon:apply_upstream_9afa10a
Draft

[libyaml]: document end fixes (9afa10a, fa1293a & 3694a4a)#103
inteon wants to merge 3 commits intoyaml:mainfrom
inteon:apply_upstream_9afa10a

Conversation

@inteon
Copy link
Copy Markdown
Contributor

@inteon inteon commented Sep 8, 2025

Copilot AI review requested due to automatic review settings September 8, 2025 09:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies three upstream changes from libyaml to improve document end tracking and handling in the YAML emitter. The changes replace a simple boolean flag with a more precise enumeration to track different types of document endings.

  • Introduces a new yamlEndType enum to replace the boolean open_ended field
  • Updates emitter logic to use the new enum values for better document end state tracking
  • Removes outdated open_ended assignments and replaces them with appropriate end_type values

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
yamlh.go Defines new yamlEndType enum and updates emitter struct to use end_type field
encode.go Updates encoder finish method to use new enum value
emitterc.go Replaces all open_ended usage with appropriate end_type enum values throughout emitter logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@inteon inteon changed the title Apply upstream 9afa10a, fa1293a & 3694a4a [libyaml]: document end fixes (9afa10a, fa1293a & 3694a4a) Sep 8, 2025
See: yaml/libyaml@9afa10a

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
See: yaml/libyaml@fa1293a

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
See: yaml/libyaml@3694a4a

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@ingydotnet ingydotnet force-pushed the apply_upstream_9afa10a branch from 2bcc0d7 to ade9ebc Compare September 8, 2025 16:46
@ingydotnet
Copy link
Copy Markdown
Member

I fixed the commit message issues from https://github.com/yaml/go-yaml/actions/runs/17546512705/job/49829110061
and force pushed back.

Copy link
Copy Markdown
Member

@ingydotnet ingydotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs to wait until we have worked out our new options strategy.

@inteon inteon marked this pull request as draft October 31, 2025 16:38
@ingydotnet
Copy link
Copy Markdown
Member

I think this PR needs to wait until we have worked out our new options strategy.

@inteon Now that we have Options in place, would you like to redo this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants