[libyaml]: document end fixes (9afa10a, fa1293a & 3694a4a)#103
[libyaml]: document end fixes (9afa10a, fa1293a & 3694a4a)#103
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR applies three upstream changes from libyaml to improve document end tracking and handling in the YAML emitter. The changes replace a simple boolean flag with a more precise enumeration to track different types of document endings.
- Introduces a new
yamlEndTypeenum to replace the booleanopen_endedfield - Updates emitter logic to use the new enum values for better document end state tracking
- Removes outdated
open_endedassignments and replaces them with appropriateend_typevalues
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yamlh.go | Defines new yamlEndType enum and updates emitter struct to use end_type field |
| encode.go | Updates encoder finish method to use new enum value |
| emitterc.go | Replaces all open_ended usage with appropriate end_type enum values throughout emitter logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
See: yaml/libyaml@9afa10a Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
See: yaml/libyaml@fa1293a Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
See: yaml/libyaml@3694a4a Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2bcc0d7 to
ade9ebc
Compare
|
I fixed the commit message issues from https://github.com/yaml/go-yaml/actions/runs/17546512705/job/49829110061 |
ingydotnet
left a comment
There was a problem hiding this comment.
I think this PR needs to wait until we have worked out our new options strategy.
@inteon Now that we have Options in place, would you like to redo this one? |
Split from #97
Applies these upstream (libyaml) changes: