Fix text-producing keys in Kitty keyboard REPORT_EVENT_TYPES mode#5824
Open
wngtk wants to merge 1 commit intoxtermjs:masterfrom
Open
Fix text-producing keys in Kitty keyboard REPORT_EVENT_TYPES mode#5824wngtk wants to merge 1 commit intoxtermjs:masterfrom
wngtk wants to merge 1 commit intoxtermjs:masterfrom
Conversation
In REPORT_EVENT_TYPES mode (CSI > 3 u), text-producing keys like Shift+1
should send the actual character ('!') for PRESS events, not CSI u escape
sequences. Only REPEAT and RELEASE events should use CSI u for text-producing
keys, while function keys use CSI u for all event types.
Fixes issue where Shift+1 was not outputting '!' character.
wngtk
force-pushed
the
fix/kitty-keyboard-text-producing-keys
branch
from
7f26b36 to
f15a790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #5823
In REPORT_EVENT_TYPES mode (CSI > 3 u), text-producing keys like Shift+1 should send the actual character ('!') for PRESS events, not CSI u escape sequences. Only REPEAT and RELEASE events should use CSI u for text-producing keys, while function keys use CSI u for all event types.
Fixes issue where Shift+1 was not outputting '!' character.