fix(codegen): trim the sql string before processing#113
Open
bertyhell wants to merge 1 commit intowsporto:mainfrom
Open
fix(codegen): trim the sql string before processing#113bertyhell wants to merge 1 commit intowsporto:mainfrom
bertyhell wants to merge 1 commit intowsporto:mainfrom
Conversation
to avoid trailing whitespace
Owner
|
I think we could avoid trimming the SQL. Keeping it unchanged might help users spot extra spaces or formatting issues directly in the I’m going to adjust the inconsistencies between the generators (pg, mysql, sqlite). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid trailing whitespace
example:
would be included in the ts file with a trailing newline:
This PR trims that sql before it gets analysed: