Update Choreo documentation to reflect support for build variables in BYOC components#1913
Update Choreo documentation to reflect support for build variables in BYOC components#1913YashodhaSamarawickrama wants to merge 3 commits intowso2:PEfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 40 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis documentation update clarifies how build-time environment variables are configured based on component type. Changes include labeling existing behavior specific to Buildpack components, updating a Maven override example by removing unnecessary inline-code formatting, removing a Google Cloud buildpacks hyperlink, and adding a new BYOC section. The BYOC section explains that build-time environment variables are supplied as Docker build ARGs during the Dockerfile build stage, with an example demonstrating ARG-referenced settings for build modes, feature flags, and dependency options. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
en/developer-docs/docs/develop-components/deploy-an-application-with-buildpacks.md (1)
174-174: Add a clickable link for the Google Cloud buildpacks reference.Line 174 currently points to external documentation as plain text; adding a direct Markdown link will make this immediately actionable for readers.
Suggested doc tweak
-For more examples, see Google Cloud's buildpacks documentation. +For more examples, see [Google Cloud buildpacks documentation](https://cloud.google.com/docs/buildpacks/overview).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/developer-docs/docs/develop-components/deploy-an-application-with-buildpacks.md` at line 174, Replace the plain-text sentence "For more examples, see Google Cloud's buildpacks documentation." with a Markdown clickable link to the Google Cloud buildpacks page so readers can open it directly (e.g., "For more examples, see Google Cloud's buildpacks documentation: https://cloud.google.com/buildpacks" converted to a Markdown link). Update the line in the deploy-an-application-with-buildpacks.md content where that sentence appears so it uses the Markdown link syntax and preserves surrounding punctuation and styling.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@en/developer-docs/docs/develop-components/deploy-an-application-with-buildpacks.md`:
- Line 174: Replace the plain-text sentence "For more examples, see Google
Cloud's buildpacks documentation." with a Markdown clickable link to the Google
Cloud buildpacks page so readers can open it directly (e.g., "For more examples,
see Google Cloud's buildpacks documentation:
https://cloud.google.com/buildpacks" converted to a Markdown link). Update the
line in the deploy-an-application-with-buildpacks.md content where that sentence
appears so it uses the Markdown link syntax and preserves surrounding
punctuation and styling.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ed7fea03-618a-4d06-a52d-d42db97ee0cf
📒 Files selected for processing (1)
en/developer-docs/docs/develop-components/deploy-an-application-with-buildpacks.md
Description
Documentation improvements:
Related issue - https://github.com/wso2-enterprise/choreo/issues/39214
Type of change
Testing
Related issues