Skip to content

Update solution.js#709

Open
pdwarkanath wants to merge 1 commit intoworkshopper:masterfrom
pdwarkanath:patch-1
Open

Update solution.js#709
pdwarkanath wants to merge 1 commit intoworkshopper:masterfrom
pdwarkanath:patch-1

Conversation

@pdwarkanath
Copy link
Copy Markdown

Using reduce rather than a loop

Using reduce rather than a loop
@ccarruitero
Copy link
Copy Markdown
Contributor

Hi @pdwarkanath

Thanks for your PR.

Your changes are not passing the linter, because the semicolon.

Personally, I think the for loop could be more easy to understand for a beginner developer.

Maybe this could be added as an alternative solution in test folder. What do you think?

@pdwarkanath
Copy link
Copy Markdown
Author

@ccarruitero Sure. Should I just add this as alternate_01.js file to the test folder?

@ccarruitero
Copy link
Copy Markdown
Contributor

@pdwarkanath following the pattern used for other files there, the file should be named valid_02.js

Make sure run npm test in your local machine to ensure linter and tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants