Skip to content

Remove Twitter row from About screen #25496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkmassel merged 4 commits into from
Apr 21, 2026
Merged

Remove Twitter row from About screen #25496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf790a2
Remove Twitter row from About screen
jkmassel Apr 14, 2026
cb49810
Add release notes for Twitter row removal
jkmassel Apr 14, 2026
befe6c6
Credit issue reporter in release notes
jkmassel Apr 14, 2026
f068734
Remove dead Twitter wiring now that the About row is gone
jkmassel Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Modules/Sources/BuildSettingsKit/BuildSettings+Live.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ extension BuildSettings {
appURLScheme = bundle.infoValue(forKey: "WPAppURLScheme")
jetpackAppURLScheme = bundle.infoValue(forKey: "WPJetpackAppURLScheme")
about = ProductAboutDetails(
twitterHandle: bundle.infoValue(forKey: "WPProductTwitterHandle"),
twitterURL: bundle.urlValue(forKey: "WPProductTwitterURL"),
blogURL: bundle.urlValue(forKey: "WPProductBlogURL")
)
zendeskSourcePlatform = bundle.infoValue(forKey: "WPZendeskSourcePlatform")
Expand Down
2 changes: 0 additions & 2 deletions Modules/Sources/BuildSettingsKit/BuildSettings+Preview.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ extension BuildSettings {
appURLScheme: "xcpreview",
jetpackAppURLScheme: "jetpack",
about: ProductAboutDetails(
twitterHandle: "@wordpress",
twitterURL: URL(string: "www.example.com")!,
blogURL: URL(string: "www.example.com")!
),
zendeskSourcePlatform: "zen",
Expand Down
2 changes: 0 additions & 2 deletions Modules/Sources/BuildSettingsKit/BuildSettings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ public struct BuildSettings: Sendable {
public var authKeychainServiceName: String

public struct ProductAboutDetails: Sendable {
public var twitterHandle: String
public var twitterURL: URL
public var blogURL: URL
}

Expand Down
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* [*] Reader: Fix an issues with Reader failing to clear cached comments if all the comments are deleted [#25482]
* [*] Reader: Fix an issue with the article view removing autoplay without showing controls [#25468]
* [*] Menus: Fix an issue with footer view in Menu Editing not resizing [#25481]
* [*] About screen: Remove the non-functional Twitter/X link - thanks @zynp-KC for reporting! [#25496]

26.8
-----
Expand Down
4 changes: 0 additions & 4 deletions Sources/Jetpack/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,10 +671,6 @@
<string>6</string>
<key>WPProductBlogURL</key>
<string>jetpack.com/blog</string>
<key>WPProductTwitterHandle</key>
<string>@jetpack</string>
<key>WPProductTwitterURL</key>
<string>twitter.com/jetpack</string>
<key>WPPushNotificationAppID</key>
<string>${WP_PUSH_NOTIFICATION_APP_ID}</string>
<key>WPZendeskSourcePlatform</key>
Expand Down
4 changes: 0 additions & 4 deletions Sources/Reader/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@
<string>6</string>
<key>WPProductBlogURL</key>
<string>jetpack.com/blog</string>
<key>WPProductTwitterHandle</key>
<string>@jetpack</string>
<key>WPProductTwitterURL</key>
<string>twitter.com/jetpack</string>
<key>WPPushNotificationAppID</key>
<string>${WP_PUSH_NOTIFICATION_APP_ID}</string>
<key>WPZendeskSourcePlatform</key>
Expand Down
4 changes: 0 additions & 4 deletions Sources/WordPress/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,10 +596,6 @@
<string>2</string>
<key>WPProductBlogURL</key>
<string>wordpress.org/news/</string>
<key>WPProductTwitterHandle</key>
<string>@WordPressiOS</string>
<key>WPProductTwitterURL</key>
<string>twitter.com/WordPressiOS</string>
<key>WPPushNotificationAppID</key>
<string>${WP_PUSH_NOTIFICATION_APP_ID}</string>
<key>WPZendeskSourcePlatform</key>
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/ViewRelated/Me/App Settings/About/AboutScreenTracker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class AboutScreenTracker {
case dismiss
case rateUs = "rate_us"
case share
case twitter
case blog
case legal
case automatticFamily = "automattic_family"
Expand Down
211 changes: 148 additions & 63 deletions WordPress/Classes/ViewRelated/Me/App Settings/About/AppAboutScreenConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@ struct WebViewPresenter {

class AppAboutScreenConfiguration: AboutScreenConfiguration {
static var appInfo: AboutScreenAppInfo {
AboutScreenAppInfo(name: (Bundle.main.object(forInfoDictionaryKey: "CFBundleDisplayName") as? String) ?? "",
version: Bundle.main.detailedVersionNumber() ?? "",
icon: UIImage(named: AppIcon.currentOrDefaultIconName) ?? UIImage())
AboutScreenAppInfo(
name: (Bundle.main.object(forInfoDictionaryKey: "CFBundleDisplayName") as? String) ?? "",
version: Bundle.main.detailedVersionNumber() ?? "",
icon: UIImage(named: AppIcon.currentOrDefaultIconName) ?? UIImage()
)
}

static let fonts = AboutScreenFonts(appName: WPStyleGuide.serifFontForTextStyle(.largeTitle, fontWeight: .semibold),
appVersion: WPStyleGuide.tableviewTextFont())
static let fonts = AboutScreenFonts(
appName: WPStyleGuide.serifFontForTextStyle(.largeTitle, fontWeight: .semibold),
appVersion: WPStyleGuide.tableviewTextFont()
)

let sharePresenter: ShareAppContentPresenter
let webViewPresenter = WebViewPresenter()
Expand All @@ -35,46 +39,79 @@ class AppAboutScreenConfiguration: AboutScreenConfiguration {
lazy var sections: [[AboutItem]] = {
[
[
AboutItem(title: TextContent.rateUs, action: { [weak self] context in
WPAnalytics.track(.appReviewsRatedApp)
self?.tracker.buttonPressed(.rateUs)
AppRatingUtility.shared.ratedCurrentVersion()
UIApplication.shared.open(AppRatingUtility.shared.appReviewUrl)
}),
AboutItem(title: TextContent.share, action: { [weak self] context in
self?.tracker.buttonPressed(.share)
self?.sharePresenter.present(for: BuildSettings.current.shareAppName, in: context.viewController, source: .about, sourceView: context.sourceView)
}),
AboutItem(title: TextContent.twitter, subtitle: BuildSettings.current.about.twitterHandle, cellStyle: .value1, action: { [weak self] context in
self?.tracker.buttonPressed(.twitter)
self?.webViewPresenter.presentInNavigationControlller(url: Links.twitter, context: context)
}),
AboutItem(title: Strings.current.blogName, subtitle: productBlogDisplayURL, cellStyle: .value1, action: { [weak self] context in
self?.tracker.buttonPressed(.blog)
self?.webViewPresenter.presentInNavigationControlller(url: Links.blog, context: context)
})
AboutItem(
title: TextContent.rateUs,
action: { [weak self] context in
WPAnalytics.track(.appReviewsRatedApp)
self?.tracker.buttonPressed(.rateUs)
AppRatingUtility.shared.ratedCurrentVersion()
UIApplication.shared.open(AppRatingUtility.shared.appReviewUrl)
}
),
AboutItem(
title: TextContent.share,
action: { [weak self] context in
self?.tracker.buttonPressed(.share)
self?.sharePresenter
.present(
for: BuildSettings.current.shareAppName,
in: context.viewController,
source: .about,
sourceView: context.sourceView
)
}
),
AboutItem(
title: Strings.current.blogName,
subtitle: productBlogDisplayURL,
cellStyle: .value1,
action: { [weak self] context in
self?.tracker.buttonPressed(.blog)
self?.webViewPresenter.presentInNavigationControlller(url: Links.blog, context: context)
}
)
],
[
AboutItem(title: TextContent.legalAndMore, accessoryType: .disclosureIndicator, action: { [weak self] context in
self?.tracker.buttonPressed(.legal)
context.showSubmenu(title: TextContent.legalAndMore, configuration: LegalAndMoreSubmenuConfiguration())
}),
AboutItem(
title: TextContent.legalAndMore,
accessoryType: .disclosureIndicator,
action: { [weak self] context in
self?.tracker.buttonPressed(.legal)
context.showSubmenu(
title: TextContent.legalAndMore,
configuration: LegalAndMoreSubmenuConfiguration()
)
}
)
],
[.jetpack, .reader].contains(BuildSettings.current.brand) ?
[
AboutItem(title: TextContent.automatticFamily, accessoryType: .disclosureIndicator, hidesSeparator: true, action: { [weak self] context in
self?.tracker.buttonPressed(.automatticFamily)
self?.webViewPresenter.presentInNavigationControlller(url: Links.automattic, context: context)
}),
AboutItem(title: "", cellStyle: .appLogos, accessoryType: .none)
] : nil,
[.jetpack, .reader].contains(BuildSettings.current.brand)
? [
AboutItem(
title: TextContent.automatticFamily,
accessoryType: .disclosureIndicator,
hidesSeparator: true,
action: { [weak self] context in
self?.tracker.buttonPressed(.automatticFamily)
self?.webViewPresenter
.presentInNavigationControlller(url: Links.automattic, context: context)
}
),
AboutItem(title: "", cellStyle: .appLogos, accessoryType: .none)
] : nil,
[
AboutItem(title: Strings.current.workWithUs, subtitle: TextContent.workWithUsSubtitle, cellStyle: .subtitle, accessoryType: .disclosureIndicator, action: { [weak self] context in
self?.tracker.buttonPressed(.workWithUs)
self?.webViewPresenter.presentInNavigationControlller(url: Links.workWithUs, context: context)
}),
AboutItem(
title: Strings.current.workWithUs,
subtitle: TextContent.workWithUsSubtitle,
cellStyle: .subtitle,
accessoryType: .disclosureIndicator,
action: { [weak self] context in
self?.tracker.buttonPressed(.workWithUs)
self?.webViewPresenter.presentInNavigationControlller(url: Links.workWithUs, context: context)
}
)
]
].compactMap { $0 }
]
.compactMap { $0 }
}()

func dismissScreen(_ actionContext: AboutItemActionContext) {
Expand All @@ -99,16 +136,35 @@ class AppAboutScreenConfiguration: AboutScreenConfiguration {
}

private enum TextContent {
static let rateUs = NSLocalizedString("Rate Us", comment: "Title for button allowing users to rate the app in the App Store")
static let share = NSLocalizedString("Share with Friends", comment: "Title for button allowing users to share information about the app with friends, such as via Messages")
static let twitter = NSLocalizedString("Twitter", comment: "Title of button that displays the app's Twitter profile")
static let legalAndMore = NSLocalizedString("Legal and More", comment: "Title of button which shows a list of legal documentation such as privacy policy and acknowledgements")
static let automatticFamily = NSLocalizedString("Automattic Family", comment: "Title of button that displays information about the other apps available from Automattic")
static var workWithUsSubtitle = AppConfiguration.isWordPress ? nil : NSLocalizedString("Join From Anywhere", comment: "Subtitle for button displaying the Automattic Work With Us web page, indicating that Automattic employees can work from anywhere in the world")
static let rateUs = NSLocalizedString(
"Rate Us",
comment: "Title for button allowing users to rate the app in the App Store"
)
static let share = NSLocalizedString(
"Share with Friends",
comment:
"Title for button allowing users to share information about the app with friends, such as via Messages"
)
static let legalAndMore = NSLocalizedString(
"Legal and More",
comment:
"Title of button which shows a list of legal documentation such as privacy policy and acknowledgements"
)
static let automatticFamily = NSLocalizedString(
"Automattic Family",
comment: "Title of button that displays information about the other apps available from Automattic"
)
static var workWithUsSubtitle =
AppConfiguration.isWordPress
? nil
: NSLocalizedString(
"Join From Anywhere",
comment:
"Subtitle for button displaying the Automattic Work With Us web page, indicating that Automattic employees can work from anywhere in the world"
)
}

private enum Links {
static let twitter = BuildSettings.current.about.twitterURL
Copy link
Copy Markdown
Contributor

@crazytonyli crazytonyli Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things can be removed:

  • The BuildSettings.current.about.twitterURL property
  • The WPProductTwitterURL entries in Info.plist files

Copy link
Copy Markdown
Contributor Author

@jkmassel jkmassel Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did some removals in 494e99b

static let blog = BuildSettings.current.about.blogURL
static let workWithUs = URL(string: Strings.current.workWithUsURL)!
static let automattic = URL(string: "https://automattic.com")!
Expand All @@ -125,21 +181,32 @@ class LegalAndMoreSubmenuConfiguration: AboutScreenConfiguration {
linkItem(title: Titles.termsOfService, link: Links.termsOfService, button: .termsOfService),
linkItem(title: Titles.privacyPolicy, link: Links.privacyPolicy, button: .privacyPolicy),
linkItem(title: Titles.sourceCode, link: Links.sourceCode, button: .sourceCode),
AboutItem(title: Titles.acknowledgements, accessoryType: .disclosureIndicator, action: { context in
let rootView = AcknowledgementsListView(viewModel: AcknowledgementsListViewModel(dataProvider: AcknowledgementsService()))
context.viewController.navigationController?.pushViewController(
UIHostingController(rootView: rootView),
animated: true
)
})
AboutItem(
title: Titles.acknowledgements,
accessoryType: .disclosureIndicator,
action: { context in
let rootView = AcknowledgementsListView(
viewModel: AcknowledgementsListViewModel(dataProvider: AcknowledgementsService())
)
context.viewController.navigationController?
.pushViewController(
UIHostingController(rootView: rootView),
animated: true
)
}
)
]
]
}()

private func linkItem(title: String, link: URL, button: AboutScreenTracker.Event.Button) -> AboutItem {
AboutItem(title: title, accessoryType: .disclosureIndicator, action: { [weak self] context in
self?.buttonPressed(link: link, context: context, button: button)
})
AboutItem(
title: title,
accessoryType: .disclosureIndicator,
action: { [weak self] context in
self?.buttonPressed(link: link, context: context, button: button)
}
)
}

private func buttonPressed(link: URL, context: AboutItemActionContext, button: AboutScreenTracker.Event.Button) {
Expand All @@ -160,10 +227,22 @@ class LegalAndMoreSubmenuConfiguration: AboutScreenConfiguration {
}

private enum Titles {
static let termsOfService = NSLocalizedString("Terms of Service", comment: "Title of button that displays the App's terms of service")
static let privacyPolicy = NSLocalizedString("Privacy Policy", comment: "Title of button that displays the App's privacy policy")
static let sourceCode = NSLocalizedString("Source Code", comment: "Title of button that displays the App's source code information")
static let acknowledgements = NSLocalizedString("Acknowledgements", comment: "Title of button that displays the App's acknowledgements")
static let termsOfService = NSLocalizedString(
"Terms of Service",
comment: "Title of button that displays the App's terms of service"
)
static let privacyPolicy = NSLocalizedString(
"Privacy Policy",
comment: "Title of button that displays the App's privacy policy"
)
static let sourceCode = NSLocalizedString(
"Source Code",
comment: "Title of button that displays the App's source code information"
)
static let acknowledgements = NSLocalizedString(
"Acknowledgements",
comment: "Title of button that displays the App's acknowledgements"
)
}

private enum Links {
Expand Down Expand Up @@ -200,13 +279,19 @@ private struct Strings {

static let wordpress = Strings(
blogName: NSLocalizedString("News", comment: "Title of a button that displays the WordPress.org blog"),
workWithUs: NSLocalizedString("Contribute", comment: "Title of button that displays the WordPress.org contributor page"),
workWithUs: NSLocalizedString(
"Contribute",
comment: "Title of button that displays the WordPress.org contributor page"
),
workWithUsURL: "https://make.wordpress.org/mobile/handbook"
)

static let a8c = Strings(
blogName: NSLocalizedString("Blog", comment: "Title of a button that displays the WordPress.com blog"),
workWithUs: NSLocalizedString("Work With Us", comment: "Title of button that displays the Automattic Work With Us web page"),
workWithUs: NSLocalizedString(
"Work With Us",
comment: "Title of button that displays the Automattic Work With Us web page"
),
workWithUsURL: "https://automattic.com/work-with-us"
)
}