Remove Twitter row from About screen#25496
Merged
Conversation
Closed
1 task
Closed
1 task
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32037 | |
| Version | PR #25496 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f068734 | |
| Installation URL | 63bf7sd0ioreg |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32037 | |
| Version | PR #25496 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f068734 | |
| Installation URL | 2qpblboh5hl0o |
crazytonyli
reviewed
Apr 21, 2026
| } | ||
|
|
||
| private enum Links { | ||
| static let twitter = BuildSettings.current.about.twitterURL |
Contributor
There was a problem hiding this comment.
A few more things can be removed:
- The
BuildSettings.current.about.twitterURLproperty - The
WPProductTwitterURLentries in Info.plist files
Collaborator
The Twitter/X link opened a blank webview because X.com doesn't render in embedded WKWebViews. Rather than switching to an external browser link, remove the row entirely — the account is inactive.
Drops the unused `twitterHandle`/`twitterURL` on `BuildSettings.ProductAboutDetails`, their `WPProductTwitter*` Info.plist keys across all three brands, and the `AboutScreenTracker.Event.Button.twitter` analytics case.
jkmassel
force-pushed
the
jkmassel/fix-about-screen-links
branch
from
494e99b to
f068734
Compare
crazytonyli
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WKWebViewAlso cleans up the now-unused
TextContent.twitterandLinks.twitterconstantsFixes #25493 — reported by @zynp-KC
Test plan