Improve minifier behavior and remove vulnerable dependencies#44
Open
tobitege wants to merge 3 commits intowolfe-labs:mainfrom
Open
Improve minifier behavior and remove vulnerable dependencies#44tobitege wants to merge 3 commits intowolfe-labs:mainfrom
tobitege wants to merge 3 commits intowolfe-labs:mainfrom
Conversation
Author
|
@matpratta - fyi: just today there was another axios npm sec thread reported by CISA, but fortunately this repo's version was locked to an older version. This makes the removal of axios with this PR even more important. |
Contributor
|
Hey @tobitege! It's been a while I don't work on this project (or anything related to DU, haven't had the game installed since they shutdown). Will try to review it over the weekend, as it's a somewhat big PR, mainly concerned about breaking the minifier behavior for others. Thanks for the PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two follow-up changes on top of
main.DULuaConfignpmdependency, which was pulling most of the reported advisories into the lockfileaxiosand replace its two GET call sites with a small local HTTP JSON helper insrc/lib/HttpClient.tslodashusage by replacing the remaining call sites with native codeyamlto^1.10.3cross-spawnso the clipboard-related transitive dependency resolves to a fixed versionpackage-lock.jsonWhy
The repository had accumulated Dependabot alerts from an older dependency tree. After these changes, the local audit is clean while the CLI still builds and starts normally.
Verification
npm installnpm auditnpm run builddu-lua help