Fix CI failures from upstream dependency drift#180
Open
LinuxJedi wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix CI failures from upstream dependency drift#180LinuxJedi wants to merge 1 commit intowolfSSL:masterfrom
LinuxJedi wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Add tpm2_crypto.c and tpm2_util.c to the wolftpm Visual Studio project. Recent wolftpm changes moved TPM2_KDFa_ex, TPM2_KDFe_ex, TPM2_AesCfbEncrypt, TPM2_HmacCompute, TPM2_HashCompute into tpm2_crypto.c and TPM2_GetHashDigestSize, TPM2_GetHashType, TPM2_ConstantCompare, TPM2_ForceZero, TPM2_PrintBin into tpm2_util.c, which caused unresolved external symbol errors on the Windows build. Pass --disable-anon to the wolfSSL configure step in the TPM 2.0 store test workflow. wolfSSL 5.9.1 added a settings.h check that rejects HAVE_ANON without DH, and this workflow builds wolfPKCS11 with --disable-dh.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI/build breakages caused by upstream wolfTPM and wolfSSL configuration changes, specifically addressing Windows Visual Studio link failures and a Linux workflow configuration incompatibility.
Changes:
- Add newly-split wolfTPM source files (
tpm2_crypto.c,tpm2_util.c) to the Visual Studiowolftpm.vcxprojto resolve missing symbols. - Update the TPM 2.0 store GitHub Actions workflow to configure wolfSSL with
--disable-anonto avoid the newHAVE_ANON+no-DH configuration rejection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IDE/VisualStudio/wolftpm.vcxproj | Adds the missing wolfTPM compilation units now required by upstream symbol layout. |
| .github/workflows/tpm2-store-test.yml | Adjusts wolfSSL configure flags to remain compatible with --disable-dh in downstream builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tpm2_crypto.c and tpm2_util.c to the wolftpm Visual Studio project. Recent wolftpm changes moved TPM2_KDFa_ex, TPM2_KDFe_ex, TPM2_AesCfbEncrypt, TPM2_HmacCompute, TPM2_HashCompute into tpm2_crypto.c and TPM2_GetHashDigestSize, TPM2_GetHashType, TPM2_ConstantCompare, TPM2_ForceZero, TPM2_PrintBin into tpm2_util.c, which caused unresolved external symbol errors on the Windows build.
Pass --disable-anon to the wolfSSL configure step in the TPM 2.0 store test workflow. wolfSSL 5.9.1 added a settings.h check that rejects HAVE_ANON without DH, and this workflow builds wolfPKCS11 with --disable-dh.