[Explore Feed] Preference Selection #6502
Open
Williamrai wants to merge 50 commits intoexplore-feed-upgrade-designfrom
Open
[Explore Feed] Preference Selection #6502Williamrai wants to merge 50 commits intoexplore-feed-upgrade-designfrom
Williamrai wants to merge 50 commits intoexplore-feed-upgrade-designfrom
Conversation
- adds interest onboarding related screens - adds string resources
- adds state models - adds viewModel and interest placeholder screen
# Conflicts: # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml
…o ef-interest # Conflicts: # app/src/main/java/org/wikipedia/onboarding/InitialOnboardingActivity.kt
- code fixes
…o ef-interest # Conflicts: # app/src/main/res/values-qq/strings.xml
…o ef-interest # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml
- moves view to its own composable functions - adds string resource - code fixes
- adds topics - code fixes
…o ef-interest # Conflicts: # app/src/main/java/org/wikipedia/onboarding/InitialOnboardingActivity.kt # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml
- code fixes
- adds deleteAllByType query - adds viewModelFactory to PersonalizationViewModel.kt - code fixes and cleanups
- writes DAO for article and topic interest - update PersonalizationViewModel.kt and PersonalizationRepository.kt - updates SelectionBottomBar to use count of both article and topics - code fixes
- adds job in PersonalizationViewModel.kt - code fixes
- update article and topic interest dao - code fixes
- code fixes
- updates db entities and adds unit test
- renames article and topic interest table
- adds string resource - adds autoSize parameter to HtmlText
# Conflicts: # app/src/main/java/org/wikipedia/feed/personalization/FeedPreferenceScreen.kt
- adds FeedPreferenceRepository and FeedPreferenceState
# Conflicts: # app/src/main/java/org/wikipedia/feed/personalization/PersonalizationViewModel.kt
…o ef-onboarding-preference # Conflicts: # app/src/main/java/org/wikipedia/feed/HomeFragment.kt # app/src/main/java/org/wikipedia/feed/personalization/PersonalizationScreen.kt # app/src/main/java/org/wikipedia/feed/personalization/PersonalizationViewModel.kt # app/src/main/java/org/wikipedia/feed/personalization/interest/InterestSelectionState.kt # app/src/main/java/org/wikipedia/onboarding/InitialOnboardingActivity.kt # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml
… using getArticlesWithTopic function - adds loadFeedPreferenceScreen - adds dev settings for selecting feed preference type - code/ui fixes
- removes db query to get articleWithTopic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Phabricator:
https://phabricator.wikimedia.org/T418781