[Feature branch] Reading challenge widget#6367
Open
Williamrai wants to merge 120 commits intomainfrom
Open
Conversation
- adds StreakProgressBar and BoxedProgressBar component - adds helper xml components for widgets
…hallenge widget state
- lint fixes
- updates widgets size - adds unit test for ReadingChallengeWidgetRepository resolveState and recalculateStreakIfNeeded function - code fixes
- adds colors, gradient background - adds preview images - adds resources
* Reading challenge: code updates and renaming * Code fix * Code review comment * Lint * Use TestCase --------- Co-authored-by: williamrai <williamrai13@gmail.com>
- adds progress color
- ui fixes
… into reading-challenge-widget-design
* ReadingChallenge: design tweaks for login/logout behaviors * Update code review comment
* - design fixes * - Tapping the widget background now opens the Explore feed - adds baby globe placeholder resource - design fixes * - adds baby globe assets as PNG - code fixes * - adds spacer with height to prevent the mascot from shifting downward in ChallengeConcludedNoStreak and ChallengeRemoved state
* - adds code to test the widget combination cycle * - code fixes
…get-design # Conflicts: # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml
… into reading-challenge-widget-design
… into reading-challenge-widget-design
- removes unused baby globe assets - code fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Phabricator:
https://phabricator.wikimedia.org/T418634