Add margin size, text justification and hyphenation to Theme settings#6320
Open
sensboston wants to merge 3 commits intowikimedia:mainfrom
Open
Add margin size, text justification and hyphenation to Theme settings#6320sensboston wants to merge 3 commits intowikimedia:mainfrom
sensboston wants to merge 3 commits intowikimedia:mainfrom
Conversation
- Add margin slider (0-10) to Theme dialog for controlling content width by overriding PCS max-width constraints via CSS injection - Add Justify and Hyphenation toggle switches - Block horizontal WebView scrolling when custom margins are active - Add translations for 18 languages Bug: T417607
sensboston
requested review from
Williamrai,
cooltey and
dbrant
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds three new user-facing options to the Reading Theme settings dialog:
injection. Default position (10) preserves current behavior.
text-align: justifyfor article content (default: on).hyphens: autofor better line breaks (default: on).Also blocks horizontal WebView scrolling when custom margins are active.
Why is this needed?
On tablets (e.g. Samsung Galaxy Tab S10+), the PCS default
max-widthleaves excessively widewhite margins on both sides of article content, reducing readability. Text justification and
hyphenation further improve the reading experience on wide screens.
These settings only take effect when users change them — default behavior is preserved for
existing users.
Includes translations for 18 languages.
https://phabricator.wikimedia.org/T417607
Here are some screenshots, from production and modified app: