Conversation
# Conflicts: # app/src/main/java/org/wikipedia/page/PageFragment.kt
… api calls - codes fixes
… api calls - codes fixes - adds categories db code, fixes refresh calls and code for sending events
cooltey
left a comment
cooltey
left a comment
There was a problem hiding this comment.
Just did a quick scan of this PR and it looks pretty good! 👍
One issue I found:
- When loading an article that has a lead image, the footer does not get loaded correctly, and it shows up after refreshing the page.
| handlePageSummary(pageSummary, request) | ||
|
|
||
| val watchStatus = watchStatusDeferred.await() | ||
| handleWatchStatusAndFetchCategories(watchStatus, request.title) |
There was a problem hiding this comment.
The fetchWatchStatus already contains the categories response, so this function should either pass the categories from the fetchWatchStatus directly, or fetch it only if the categories is empty.
There was a problem hiding this comment.
done, the current logic fetches data based on the applied conditions.
| val Factory: ViewModelProvider.Factory = viewModelFactory { | ||
| initializer { | ||
| val app = this[APPLICATION_KEY] as WikipediaApp | ||
| PageLoadViewModel(app) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you please explain it a bit, and what's the difference if we set a val app = WikipediaApp.instance directly in the view model class?
There was a problem hiding this comment.
Functionally, there won’t be a difference since WikipediaApp instance is an object and can be accessed easily everywhere, but ideally, any external dependencies should be injected into the ViewModel even the dataFetcher that i have. I will remove this since this can create confusion.
the read more is loading lazily for me, i can a slight delay though |
As per discussion, the issue arises rarely and its difficult to reproduce, will monitor this. |
Williamrai
added
the
HOLD
# Conflicts: # app/src/main/java/org/wikipedia/page/PageFragment.kt
# Conflicts: # app/src/main/java/org/wikipedia/page/PageFragment.kt # app/src/main/java/org/wikipedia/page/PageFragmentLoadState.kt
2 participants
What does this do?
Phabricator:
https://phabricator.wikimedia.org/T303945