Closes #8: Adds support for the rdap flag in RequestParameters#9
Open
yfidouh wants to merge 3 commits intowhois-api-llc:mainfrom
Open
Closes #8: Adds support for the rdap flag in RequestParameters#9yfidouh wants to merge 3 commits intowhois-api-llc:mainfrom
yfidouh wants to merge 3 commits intowhois-api-llc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds an rdap parameter to RequestParameters, allowing users to pass rdap=1 (or 0) as part of the request.
Changes
Introduced the rdap flag with basic validation.
Added a test case confirming rdap is correctly included in the parameters.
Closes #8
All tests pass locally. Let me know if you need any adjustments.