Conversation
Deploying rspack with
|
| Latest commit: |
c8a72f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f8ab169.rspack-v2.pages.dev |
| Branch Preview URL: | https://chenjiahan-chore-rspack-dev.rspack-v2.pages.dev |
📦 Binary Size-limit
❌ Size increased by 14.01MB from 48.76MB to 62.77MB (⬆️28.73%) |
There was a problem hiding this comment.
Pull request overview
Updates the repo to use the stable @rspack/dev-server@2.0.0 instead of 2.0.0-rc.* across templates, examples, CLI tooling, e2e fixtures, and migration documentation.
Changes:
- Bump
@rspack/dev-serverdependency specifiers from2.0.0-rc.*to^2.0.0in examples, create-rspack templates, CLI, and e2e fixtures. - Refresh migration docs (EN/ZH) to show the stable dev-server version in the upgrade snippet.
- Update
pnpm-lock.yamlto resolve@rspack/dev-server@2.0.0.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/migration/rspack_1.x.mdx | Updates migration snippet to stable @rspack/dev-server version. |
| website/docs/en/guide/migration/rspack_1.x.mdx | Updates migration snippet to stable @rspack/dev-server version. |
| tests/e2e/package.json | Uses stable @rspack/dev-server for e2e fixture dependencies. |
| pnpm-lock.yaml | Locks @rspack/dev-server to 2.0.0 and updates importer specifiers. |
| packages/rspack-cli/package.json | Updates CLI devDependency to stable @rspack/dev-server. |
| packages/create-rspack/template-vue-ts/package.json | Updates template dev-server dependency to stable ^2.0.0. |
| packages/create-rspack/template-vue-js/package.json | Updates template dev-server dependency to stable ^2.0.0. |
| packages/create-rspack/template-vanilla-ts/package.json | Updates template dev-server dependency to stable ^2.0.0. |
| packages/create-rspack/template-vanilla-js/package.json | Updates template dev-server dependency to stable ^2.0.0. |
| packages/create-rspack/template-react-ts/package.json | Updates template dev-server dependency to stable ^2.0.0. |
| packages/create-rspack/template-react-js/package.json | Updates template dev-server dependency to stable ^2.0.0. |
| examples/vanilla/package.json | Updates example dev-server dependency to stable ^2.0.0. |
| examples/react/package.json | Updates example dev-server dependency to stable ^2.0.0. |
| examples/basic/package.json | Updates example dev-server dependency to stable ^2.0.0. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@rspack/core": "^2.0.0-rc.0", | ||
| "@rspack/cli": "^2.0.0-rc.0", | ||
| "@rspack/dev-server": "^2.0.0-rc.0", | ||
| "@rspack/dev-server": "^2.0.0", | ||
| "@rspack/plugin-react-refresh": "^2.0.0" |
There was a problem hiding this comment.
The text above this snippet says the packages should “stay in sync” with @rspack/core, but the example now mixes @rspack/core/@rspack/cli RC versions with a stable @rspack/dev-server version. Consider clarifying the wording to “latest compatible versions” (or explicitly note that @rspack/dev-server@^2.0.0 is compatible with @rspack/core@^2.0.0-rc.0) so readers don’t interpret this as a mismatch/error.
| "@rspack/core": "^2.0.0-rc.0", | ||
| "@rspack/cli": "^2.0.0-rc.0", | ||
| "@rspack/dev-server": "^2.0.0-rc.0", | ||
| "@rspack/dev-server": "^2.0.0", | ||
| "@rspack/plugin-react-refresh": "^2.0.0" |
There was a problem hiding this comment.
该示例现在混用了 @rspack/core/@rspack/cli 的 RC 版本与稳定版 @rspack/dev-server(^2.0.0)。但上文提到要与 @rspack/core “保持同步”,这可能让读者误以为示例版本不一致有问题。建议把表述改为“升级到最新兼容版本”,或明确说明稳定版 dev-server 与 @rspack/core@^2.0.0-rc.0 是兼容的。
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Summary
@rspack/dev-serverreferences from the2.0.0-rcbuilds to^2.0.0across examples, create-rspack templates, the CLI package, and e2e fixtures.Related links
Checklist