feat: support typescript build mode#9870
Open
lishaduck wants to merge 1 commit intovitest-dev:mainfrom
Open
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
lishaduck
changed the title
Contributor
Author
|
CI's just a flake, playwright test timed out. Won't waste CI on it 'nless ya ask me to :) |
3 tasks
sheremet-va
added
the
p2-to-be-discussed
Member
|
Doesn't it generate files on the system? |
Contributor
Author
Yes, that's the point. "build mode" builds the projects because they need the |
sheremet-va
requested changes
Mar 27, 2026
Member
sheremet-va
left a comment
sheremet-va
left a comment
There was a problem hiding this comment.
The implementation looks good, but can you add a test for this feature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9865
Resolves #3752
Supersedes flint-fyi/flint#2427
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci. <--test:cifailed b/c browser mode,pnpm testmostly passes 🤷🏻♂️Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.