fix: clamp slowTestThreshold to max 32-bit int for setTimeout#10161
Open
mixelburg wants to merge 1 commit intovitest-dev:mainfrom
Open
fix: clamp slowTestThreshold to max 32-bit int for setTimeout#10161mixelburg wants to merge 1 commit intovitest-dev:mainfrom
mixelburg wants to merge 1 commit intovitest-dev:mainfrom
Conversation
When slowTestThreshold is set to Infinity (or any value exceeding 2^31-1), Node.js setTimeout triggers a TimeoutOverflowWarning and falls back to 1ms timeout, causing slow test indicators to flash immediately. Clamp the value to 2_147_483_647 (max 32-bit signed integer) in both onHookStart and onTestStart methods. Fixes vitest-dev#10155
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
added
the
maybe automated
|
Hello @mixelburg. Your PR has been labeled If you're a real person behind this contribution, please:
If you believe this was flagged by mistake, leave a comment. These measures help us reduce maintenance burden and keep the team's work efficient. See our AI contributions policy for more context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10155
Problem
When
slowTestThresholdis set toInfinity(e.g., to suppress slow test warnings), Node.jssetTimeoutthrows aTimeoutOverflowWarningbecauseInfinityexceeds the 32-bit signed integer limit, falling back to 1ms timeout. This causes slow test indicators to flash immediately instead of being suppressed.Fix
Clamp the
slowTestThresholdvalue to2_147_483_647(max 32-bit signed integer) before passing it tosetTimeoutin bothonHookStartandonTestStartmethods of theSummaryReporter.