Open
Conversation
This version adds bundled types, and a `toNotFake` API to complement `toFake` - Use bundled types instead of @types/sinonjs__fake-timers - Allow passing toNotFake into `vi.useFakeTimers()`
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
added
the
p2-nice-to-have
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating fake-timers to v15.3.0
This version adds bundled types, a fix to properly restore cancelIdleCallback when uninstalling fake timers, and a
toNotFakeAPI to complementtoFakevi.useFakeTimers()AI disclaimer: This code was AI generated with Copilot using the Sonnet model. I babysat it heavily and iterated to make sure it matches existing patterns and produced as minimal a change as possible.
Question for reviewers
At the moment, toNotFake will require the user to add
nextTickto ensure that nextTick is not mocked, otherwise we'll often throw an error. Should that be added by default?Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.