Generalize encoding and decoding to work for all numbers that implement num_traits::Float#1
Open
Trevader24135 wants to merge 7 commits intovenkat0791:mainfrom
Open
Generalize encoding and decoding to work for all numbers that implement num_traits::Float#1Trevader24135 wants to merge 7 commits intovenkat0791:mainfrom
Trevader24135 wants to merge 7 commits intovenkat0791:mainfrom
Conversation
added 7 commits
February 3, 2026 20:16
…axstar when both inputs are infinite
Owner
|
Thanks, @Trevader24135. Kindly note that it will take me a while to get to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the encoder work generally with either
f32orf64is quite helpful to me. I like to run simulations with higher resolutions usingf64, but if I'm creating a piece of software that should keep up in real time, I prefer to usef32. Being able to use either is nice.This pull also adds criterion benchmarks so that if I find the time, I can try to optimize some of the algorithms used in this library to speed up it's performance, because I find that it's slower than other implementations such as Aff3ct.
Finally, this pull also separates out the dependencies required for the binary crate this library provides into their own feature which is disabled by default, so that consuming projects don't pull in unnecessary dependencies. This perhaps should have been it's own pull request, but I went ahead and did it anyways. If that's undesirable, then I can go back and undo that for now, though long-term I personally think it's a good idea.