fix(assertString): throw typeError on objects with constructor and name property#2692
Open
newtondividedbysqm wants to merge 6 commits intovalidatorjs:masterfrom
Open
fix(assertString): throw typeError on objects with constructor and name property#2692newtondividedbysqm wants to merge 6 commits intovalidatorjs:masterfrom
newtondividedbysqm wants to merge 6 commits intovalidatorjs:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates assertString to correctly reject non-string objects that spoof constructor.name as "String", and expands tests to cover the spoofing cases (and boxed strings).
Changes:
- Tighten
assertStringtype checking to allow primitives/boxed strings while rejecting constructor-name spoofed objects. - Add unit tests for spoofed
{ constructor: { name: "String" } }inputs. - Add a unit test ensuring boxed strings (
new String(...)) are accepted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/lib/util/assertString.js |
Reworks the validation logic to avoid constructor-name spoofing. |
test/util.test.js |
Adds regression tests for spoofed objects and boxed strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Please fix the tests and look through the Copilot comments before we review this |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2692 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2595 2588 -7
Branches 659 657 -2
=========================================
- Hits 2595 2588 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… when executed in a different context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertString is currently validating objects with constructor property like
{constructor: {name: "String"}}