refactor: simplify bundler-utoopack config assembly#13291
Draft
fireairforce wants to merge 3 commits intomasterfrom
Draft
refactor: simplify bundler-utoopack config assembly#13291fireairforce wants to merge 3 commits intomasterfrom
fireairforce wants to merge 3 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Size Change: +202 B (0%) Total Size: 9.96 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactors
packages/bundler-utoopack/src/config.tsto reduce duplicated dev/prod config assembly logic.What Changed
definevalues and extra Babel plugin featuresgetProdUtooPackConfigandgetDevUtooPackConfigconcatenateModules,persistentCaching, and dev watch flagsWhy
Both config builders were maintaining nearly identical logic for alias resolution, styles, externals, SVG handling, copy behavior, and define injection. Centralizing that flow makes the file easier to read and lowers the risk of the two paths drifting apart.
Validation
pnpm prettier --check packages/bundler-utoopack/src/config.tspnpm --filter @umijs/bundler-utoopack build