Fix: validate action runs.main before bumping SHAs#738
Fix: validate action runs.main before bumping SHAs#738yogendrasinghx wants to merge 9 commits intomainfrom
Conversation
|
👋 Hello @yogendrasinghx, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Nice addition overall—the validation step should prevent many bad SHA bumps. I found two correctness gaps to address before merging: JavaScript actions with runs.using: node* but missing main are still treated as valid, and relative runs.main paths can be mis-resolved during the entrypoint existence check.
💬 Posted 2 inline comments
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Good safeguard overall for broken action bumps, but the new validation currently treats reusable workflows as invalid actions and will skip legitimate updates. Fixing that edge case would make this PR safe to merge.
💬 Posted 1 inline comment
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 3
Made with ❤️ by Ultralytics Actions
Good addition overall: validating action refs before bumping SHAs should prevent a real class of broken updates. The main issue is that the reusable-workflow exclusion regex is currently wrong and will cause valid workflow refs to be skipped. I also see a reliability risk from regex-parsing YAML, which can misclassify valid manifests depending on formatting.
💬 Posted 2 inline comments
…ci-failing-broken-vercelrepository-dispatch' into yogendrasingh/p-1330-playwright-ci-failing-broken-vercelrepository-dispatch # Conflicts: # actions/dependabot.py
|
@yogendrasinghx I've merged the companion PR in portal. Is this one good to merge? |
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Adds a validation step to confirm an action’s manifest and declared
runs.mainentrypoint exist before updating pinned SHAs, preventing invalid Dependabot-style bumps. 🔍📊 Key Changes
action_is_valid(action, ref, token)inactions/dependabot.pyto verifyaction.ymloraction.yamlexists for a target ref.runsblock and checks whether any declaredmainJavaScript entrypoint is present in the repository contents.🎯 Purpose & Impact
ultralytics/actionsby catching invalid upstream releases earlier.