Skip to content

Just prettify build.c + setbuf, added .gitignore.#1276

Open
Guthib-of-Dan wants to merge 3 commits intouNetworking:masterfrom
Guthib-of-Dan:improve-build
Open

Just prettify build.c + setbuf, added .gitignore.#1276
Guthib-of-Dan wants to merge 3 commits intouNetworking:masterfrom
Guthib-of-Dan:improve-build

Conversation

@Guthib-of-Dan
Copy link
Copy Markdown

I literally did almost nothing extraordinary, just put newlines for compilation commands, log sections like lsquic/boringssl/linking, "setbuf" to see logs immediately in GitHub Actions.

Added "-DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 " to MacOS builds because GitHub Actions used to flood with logs about version mismatch. These lines of code literally force MacOS-12, while GitHub Actions use MacOS-15:

    /* Apple special case */
    build("clang -target x86_64-apple-macos12",
          "clang++ -stdlib=libc++ -target x86_64-apple-macos12",
          "-undefined dynamic_lookup" MACOS_LINK_EXTRAS,
          OS,
          X64);

    /* Try and build for arm64 macOS 12 */
    build("clang -target arm64-apple-macos12",
          "clang++ -stdlib=libc++ -target arm64-apple-macos12",
          "-undefined dynamic_lookup" MACOS_LINK_EXTRAS,
          OS,
          ARM64);

As you can see here https://github.com/Guthib-of-Dan/uWebSockets.js/actions/runs/24628414774, everything compiles successfully. And PR is just about readability + pretty simple

Comment thread .github/workflows/build.yml Outdated
if: matrix.os == 'windows-latest'
uses: ilammy/setup-nasm@v1.2.1

# As it turns out, Windows already has nmake preinstalled -> no supply chain attacks possible
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nmake is part of Visual C++, but this step is not nmake, it's nasm (Netwide Assembler). Is nasm really part of the default GitHub Action images?

Copy link
Copy Markdown
Author

@Guthib-of-Dan Guthib-of-Dan Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How interesting. It compiles... Alright. I'll uncomment that. We lose nothing in the end of the day
Just a minute

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

…bmodules, made Makefile produce only 'build.exe', prettified build.c + silenced curl + removed version mismatch for MacOS when compiling
@Guthib-of-Dan
Copy link
Copy Markdown
Author

Guthib-of-Dan commented Apr 20, 2026

if ( this PR is reviewed ) {
// Is it going to be merged?
// Or I can make next commits to it that will be reviewed one by one? Surely if I make one commit, I will wait until it is accepted before making next. I got such thought due to the whole idea of transforming build, which ... consists of a few steps
}
Actually if something goes wrong reverting commit makes one more commit, so it is better to make several pull requests.

Just thoughts aloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants