Just prettify build.c + setbuf, added .gitignore.#1276
Just prettify build.c + setbuf, added .gitignore.#1276Guthib-of-Dan wants to merge 3 commits intouNetworking:masterfrom
Conversation
| if: matrix.os == 'windows-latest' | ||
| uses: ilammy/setup-nasm@v1.2.1 | ||
|
|
||
| # As it turns out, Windows already has nmake preinstalled -> no supply chain attacks possible |
There was a problem hiding this comment.
nmake is part of Visual C++, but this step is not nmake, it's nasm (Netwide Assembler). Is nasm really part of the default GitHub Action images?
There was a problem hiding this comment.
How interesting. It compiles... Alright. I'll uncomment that. We lose nothing in the end of the day
Just a minute
…bmodules, made Makefile produce only 'build.exe', prettified build.c + silenced curl + removed version mismatch for MacOS when compiling
|
if ( this PR is reviewed ) { Just thoughts aloud. |
I literally did almost nothing extraordinary, just put newlines for compilation commands, log sections like lsquic/boringssl/linking, "setbuf" to see logs immediately in GitHub Actions.
Added "-DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 " to MacOS builds because GitHub Actions used to flood with logs about version mismatch. These lines of code literally force MacOS-12, while GitHub Actions use MacOS-15:
As you can see here https://github.com/Guthib-of-Dan/uWebSockets.js/actions/runs/24628414774, everything compiles successfully. And PR is just about readability + pretty simple