Temporarily commented out Daikon in CI until Daikon release 5.8.24#7657
Temporarily commented out Daikon in CI until Daikon release 5.8.24#7657mernst merged 3 commits intotypetools:masterfrom
Conversation
📝 WalkthroughWalkthroughThis change disables Daikon-related CI jobs across Azure Pipelines and CircleCI by removing the daikon_part1/2/3 job definitions and their invocations (including JDK 25 variants) and replacing them with commented placeholders and an inline note that Daikon is temporarily disabled until release 5.8.24. CircleCI also drops JDK 11 test jobs and updates the canary container image tag. All edits are limited to CI configuration and template files; no application code or exported/public language entities were changed. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.circleci/config.yml (2)
436-446:⚠️ Potential issue | 🔴 CriticalBlocker: workflow references removed Daikon jobs.
The
daikon_part1_jdk25,daikon_part2_jdk25, anddaikon_part3_jdk25job definitions were removed from thejobs:section, but they are still listed underworkflows.build.jobs. CircleCI will fail config validation (job X not found) and no jobs will run.Remove these three workflow entries (or comment them out) alongside the job-definition removal.
🔧 Proposed fix
- - daikon_part1_jdk25: - requires: - - canary_jobs - - - daikon_part2_jdk25: - requires: - - canary_jobs - - - daikon_part3_jdk25: - requires: - - canary_jobs - + # TEMPORARILY commented until Daikon release 5.8.24. + # - daikon_part1_jdk25: + # requires: + # - canary_jobs + # - daikon_part2_jdk25: + # requires: + # - canary_jobs + # - daikon_part3_jdk25: + # requires: + # - canary_jobs🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.circleci/config.yml around lines 436 - 446, The workflow still references removed jobs daikon_part1_jdk25, daikon_part2_jdk25, and daikon_part3_jdk25 under workflows.build.jobs which causes CircleCI validation errors; remove or comment out the three entries named daikon_part1_jdk25, daikon_part2_jdk25, and daikon_part3_jdk25 from the workflows.build.jobs list (or replace them with the correct existing job names) so the workflow only references jobs that are defined in the jobs: section.
401-404:⚠️ Potential issue | 🔴 CriticalBlocker:
misc_jdk11workflow entry references a removed job.Per the PR summary, the
misc_jdk11job definition was removed, but the workflow still requires it here. This will cause CircleCI config validation to fail.🔧 Proposed fix
- - misc_jdk11: - requires: - - canary_jobs - - misc_jdk25 -🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.circleci/config.yml around lines 401 - 404, The workflow entry still lists the removed job misc_jdk11 as a required dependency, causing CircleCI validation to fail; update the workflow block that contains "misc_jdk11" so it no longer references the removed job—either remove the "misc_jdk11:" entry entirely or adjust the requires list under the relevant workflow to replace or drop "misc_jdk11" (ensure dependencies like canary_jobs and misc_jdk25 remain correct), and run CircleCI config validation to confirm the fix.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.circleci/config.yml:
- Around line 436-446: The workflow still references removed jobs
daikon_part1_jdk25, daikon_part2_jdk25, and daikon_part3_jdk25 under
workflows.build.jobs which causes CircleCI validation errors; remove or comment
out the three entries named daikon_part1_jdk25, daikon_part2_jdk25, and
daikon_part3_jdk25 from the workflows.build.jobs list (or replace them with the
correct existing job names) so the workflow only references jobs that are
defined in the jobs: section.
- Around line 401-404: The workflow entry still lists the removed job misc_jdk11
as a required dependency, causing CircleCI validation to fail; update the
workflow block that contains "misc_jdk11" so it no longer references the removed
job—either remove the "misc_jdk11:" entry entirely or adjust the requires list
under the relevant workflow to replace or drop "misc_jdk11" (ensure dependencies
like canary_jobs and misc_jdk25 remain correct), and run CircleCI config
validation to confirm the fix.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 68f48e85-ef18-4125-a510-223ba0538461
📒 Files selected for processing (3)
.azure/azure-pipelines.yml.azure/jobs.m4.circleci/config.yml
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.circleci/config.yml (1)
401-404:⚠️ Potential issue | 🔴 CriticalRemove workflow reference to undefined job
misc_jdk11.The workflow entry at lines 401-404 references
misc_jdk11, but this job definition is no longer present in the config. CircleCI will fail to validate and start the pipeline with an "unknown job" error.Remove the workflow block:
- misc_jdk11: requires: - canary_jobs - misc_jdk25🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.circleci/config.yml around lines 401 - 404, The workflow references an undefined job misc_jdk11 which will break CircleCI; remove the entire workflow entry for misc_jdk11 (the block that lists misc_jdk11 with its requires array referencing canary_jobs and misc_jdk25) so the workflow no longer references this non-existent job and dependencies remain valid.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.circleci/config.yml:
- Around line 436-439: The generated YAML contains unexpanded M4 macro calls
because the macro invocations in config.yml.m4 were prefixed with '#' so M4
never expanded them; update the .m4 template to let
job_dependences_not_in_canary(canary_version, daikon_part1|part2|part3) expand
and have the template emit the expanded workflow block already commented (prefix
each emitted line with '# ') so the generated config.yml shows the actual
commented workflow entries rather than raw M4 syntax.
---
Outside diff comments:
In @.circleci/config.yml:
- Around line 401-404: The workflow references an undefined job misc_jdk11 which
will break CircleCI; remove the entire workflow entry for misc_jdk11 (the block
that lists misc_jdk11 with its requires array referencing canary_jobs and
misc_jdk25) so the workflow no longer references this non-existent job and
dependencies remain valid.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: e9a06b63-5210-4be4-8164-ef61fc974159
📒 Files selected for processing (4)
.azure/azure-pipelines-daily.yml.azure/azure-pipelines-daily.yml.m4.circleci/config.yml.circleci/config.yml.m4
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.azure/azure-pipelines.yml:
- Around line 204-205: The generated YAML contains an unexpanded M4 macro call
"daikon_job(canary_version)" appearing as a raw comment; update the source
template (azure-pipelines.yml.m4) so that when the canary job is intentionally
disabled it emits the expanded pipeline block with each line prefixed by "#" (or
otherwise comments out the expanded lines) instead of leaving the macro call
verbatim, ensuring the generated azure-pipelines.yml shows the commented job
contents rather than the M4 invocation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b067829d-bc7d-4258-aee7-7c51f2bcd976
📒 Files selected for processing (4)
.azure/azure-pipelines.yml.azure/jobs.m4.circleci/config.yml.circleci/config.yml.m4
1 participant
No description provided.