Fix: pass protocol to Meta.from_info in _filter_changed (fixes treeverse/dvc#10594)#656
Merged
skshetry merged 1 commit intotreeverse:mainfrom Feb 27, 2026
Merged
Conversation
`Meta.from_info(info)` without the `protocol` arg only checks lowercase `"etag"` key, but S3's `s3fs` returns ETags with uppercase `"ETag"`. This causes `meta.etag` to always be `None` for S3 sources, breaking `import-url --no-download` + `pull` (treeverse/dvc#10594). The fix matches the correct usage in `save.py:_meta_matches`, which already passes `fs.protocol`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
+ Coverage 72.42% 73.82% +1.40%
==========================================
Files 67 65 -2
Lines 5132 5357 +225
Branches 605 622 +17
==========================================
+ Hits 3717 3955 +238
+ Misses 1227 1209 -18
- Partials 188 193 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skshetry
approved these changes
Feb 27, 2026
Collaborator
|
@ryan-williams, thank you for contributing. Could you please sign the CLA? |
Collaborator
ryan-williams
added a commit
to runsascoded/dvx
that referenced
this pull request
Feb 27, 2026
Upstream merged our fix (treeverse/dvc-data#656) and released 3.18.3. Drop the git direct reference and `allow-direct-references` hatch config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_filter_changed()infetch.pycallsMeta.from_info(info)without theprotocolargument, so for S3 sources the ETag is never extracted (S3'ss3fsreturns"ETag"with uppercase key;Meta.from_infowithout protocol only checks lowercase"etag").This breaks
import-url --no-download+pullfor S3 sources: the ETag comparison always fails, the entry is dropped, fetch reports "Everything is up to date", and checkout fails because the file isn't in cache.Fix
This matches the correct usage in
save.py:_meta_matches(same commitf398036), which already passesfs.protocol.Related