llms/openai: openai client: return context.Canceled instead of new error declaration#1480
Open
llms/openai: openai client: return context.Canceled instead of new error declaration#1480
Conversation
…on on context cancelation
Author
|
To prevent breaking implementation, we could join errors also, let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning the standard
context.Cancelederror fromllms/openai/internal/openaiclient/openaiclient.goinstead of a new declaration, so callers can evaluate it down the line.Moreover, since cancelled can be spelled with both 1 and 2
L, it is error prone. Go's standard declaration uses 1L.before
after
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.