fix: Add extra_body to OpenAI client chat request#1453
Open
majiayu000 wants to merge 2 commits intotmc:mainfrom
Open
fix: Add extra_body to OpenAI client chat request#1453majiayu000 wants to merge 2 commits intotmc:mainfrom
majiayu000 wants to merge 2 commits intotmc:mainfrom
Conversation
Add support for extra_body parameter to allow passing custom parameters to the OpenAI API. This enables users to use beta features or new parameters without requiring library updates. - Add ExtraBody field to ChatRequest struct - Update MarshalJSON to merge ExtraBody fields into request - Add WithExtraBody call option - Add comprehensive unit tests Fixes tmc#1436 Signed-off-by: majiayu000 <1835304752@qq.com>
len() for nil maps returns 0, so the nil check is redundant. This fixes the staticcheck S1009 lint error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1436 by adding support for the
extra_bodyparameter to the OpenAI client, similar to the official Python client.Changes
ExtraBodyfield toChatRequeststruct for passing custom parametersExtraBodyfields into the request bodyWithExtraBody()call option for users to pass custom parameters via metadataUse Case
This allows users to pass beta features or new OpenAI parameters (e.g.,
parallel_tool_calls) without requiring library updates:Testing
WithExtraBodyoptionExtraBodyfieldGenerated with Claude Code