🐛 Fix chunk.getModules() webpack 5 deprecation warning#28
Open
slorber wants to merge 1 commit intothemgoncalves:masterfrom
Open
🐛 Fix chunk.getModules() webpack 5 deprecation warning#28slorber wants to merge 1 commit intothemgoncalves:masterfrom
slorber wants to merge 1 commit intothemgoncalves:masterfrom
Conversation
(node:38087) [DEP_WEBPACK_CHUNK_GET_MODULES] DeprecationWarning: Chunk.getModules: Use new ChunkGraph API
Contributor
Author
|
On the Docusaurus PR (facebook/docusaurus#4089), we'll be using my local fork Deploy preview at https://deploy-preview-4089--docusaurus-2.netlify.app/ |
RDIL
reviewed
Mar 30, 2021
| this.getEntrypoints(this.stats.entrypoints); | ||
|
|
||
| this.getAssets(this.getMinimalStatsChunks(compilation.chunks)); | ||
| this.getAssets(this.getMinimalStatsChunks(compilation.chunks, compilation.chunkGraph)); |
Contributor
There was a problem hiding this comment.
Just in case this isn't present for webpack 4
Suggested change
| this.getAssets(this.getMinimalStatsChunks(compilation.chunks, compilation.chunkGraph)); | |
| this.getAssets(this.getMinimalStatsChunks(compilation.chunks, compilation.chunkGraph || null)); |
Contributor
Author
There was a problem hiding this comment.
I don't think chunkGraph is present in webpack4, but not sure to understand why this call is needed? Do we want null instead of undefined?
Contributor
There was a problem hiding this comment.
That's true. Just trying to avoid strict mode madness where possible, but this might not be entirely needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of the work of @RDIL for Docusaurus 2 to support Webpack 5 (facebook/docusaurus#4089)
We have a Webpack 5 deprecation warning:
chunk.getModules()is deprecated and should be replaced by thechunkGraphAPI.To help review, wasn't able to find doc about the new
ChunkGraphAPI, but it seems it is equivalent, asgetModules()use this new API now and just add a deprecation warningWhy
Support Webpack 5 without warnings
Checklist
errorsorwarningsapproved terminologyunit tests, if apply.Emojis for categorizing pull requests:
🐛 Bug fix (
:bug:)