fix(main/turbopack): condense and revise by robertkirkman · Pull Request #29207 · termux/termux-packages

robertkirkman · 2026-04-04T23:33:14Z

Bulk-patch "android" wherever it can condense the patches using find on $TERMUX_PKG_SRCDIR and rustls-platform-verifier
Organize add_android_build.patch into the bulk-patches plus three smaller .patch files that group related changes together, disable-wasm-fallback-for-android.patch, modify-allocator-for-android.patch and modify-file-locking-for-android.patch
Use CARGO_TARGET_NAME instead of redefining a new variable with the same contents, RUST_TARGET
Apply --yes to npx pnpm install for noninteractive building outside of GitHub Actions
Remove unnecessary ls -l command
Remove unnecessary ${STRIP} commands; termux_step_strip_elf_symbols() does that automatically
Reorganize termux_step_pre_configure() to contain all external dependency fetching and environment variable setting, and termux_step_make() to contain only the build command
Implement the fallback binary using a symbolic link to the regular binary, saving space in the package.
Apply x86_64-linux-android triplet to napi array in packages/next-swc/package.json

- Bulk-patch `"android"` wherever it can condense the patches using `find` on `$TERMUX_PKG_SRCDIR` and `rustls-platform-verifier` - Organize `add_android_build.patch` into the bulk-patches plus three smaller `.patch` files that group related changes together, `disable-wasm-fallback-for-android.patch`, `modify-allocator-for-android.patch` and `modify-file-locking-for-android.patch` - Use `CARGO_TARGET_NAME` instead of redefining a new variable with the same contents, `RUST_TARGET` - Apply `--yes` to `npx pnpm install` for noninteractive building outside of GitHub Actions - Remove unnecessary `ls -l` command - Remove unnecessary `${STRIP}` commands; `termux_step_strip_elf_symbols()` does that automatically - Reorganize `termux_step_pre_configure()` to contain all external dependency fetching and environment variable setting, and `termux_step_make()` to contain only the build command - Implement the fallback binary using a symbolic link to the regular binary, saving space in the package. - Apply `x86_64-linux-android` triplet to `napi` array in `packages/next-swc/package.json`

robertkirkman · 2026-04-05T00:12:00Z

@xingguangcuican6666 @Kuldeep-Dilliwar I wanted to ask,

Do these changes all look ok to you?
Could you test the GitHub Actions artifacts from this PR and make sure that everything is still working the same after this? It is for me, but I'm not 100% sure.

robertkirkman · 2026-04-05T00:14:32Z

-+            let env_var = std::env::var("TURBO_SSL_CERT_FILE");
-+
-+            // --- BRANCH A: TERMUX MODE (Fix the Crash) ---
-+            if termux_path.exists() {


I believe that my version does not require this patch in this way.

However, I have not been able to conclusively confirm that, because I do not know how to reproduce the exact error that this patch fixes.

@Kuldeep-Dilliwar do you know how to reproduce the exact error that this patch about /data/data/com.termux/files/usr/etc/tls/cert.pem fixes, so I can test my version to confirm that it is not affected by the error anymore even without having this patch?

xingguangcuican6666 · 2026-04-05T02:37:07Z

@xingguangcuican6666 @Kuldeep-Dilliwar I wanted to ask,

Do these changes all look ok to you?

Could you test the GitHub Actions artifacts from this PR and make sure that everything is still working the same after this? It is for me, but I'm not 100% sure.

It seems that there is no problem. I will conduct a functionality test later.

xingguangcuican6666 · 2026-04-05T02:47:11Z

After my testing, it seems that there is indeed no problem, but I found that /data/data/com.termux/files/usr/etc/profile.d/turbopack.sh does not source automatically and needs to be sourced manually.

robertkirkman · 2026-04-05T02:53:10Z

After my testing, it seems that there is indeed no problem, but I found that /data/data/com.termux/files/usr/etc/profile.d/turbopack.sh does not source automatically and needs to be sourced manually.

This is known about; I explained that it is necessary to use exit and then open Termux again after installing turbopack here:

[Bug]: Error: turbo.createProject is not supported by the wasm bindings. #27937 (comment)

Maybe I should add a line to the postinst script print message that explains that is necessary.

However, that is also necessary for other things in Termux and also often on Desktop Linux as well, such as for example C# programs like jellyfin-server, and those don't have postinst messages explaining this - they just assume the users will know that. I'm not sure what option is best.

Kuldeep-Dilliwar · 2026-04-05T03:04:56Z

@xingguangcuican6666 @Kuldeep-Dilliwar I wanted to ask,

Do these changes all look ok to you?

Could you test the GitHub Actions artifacts from this PR and make sure that everything is still working the same after this? It is for me, but I'm not 100% sure.

This is the issues that i added those harcoded cert file location from Termux, in this image I have used artifect from build, and the reason about adding the env was that, because in one feature of nextjs you can use your corporate companies SSL cert which is provided by your company, so i thought I could make a env which people or user can point to and that will be added to know cert list.

xingguangcuican6666 · 2026-04-05T03:14:51Z

This is known about; I explained that it is necessary to use exit and then open Termux again after installing turbopack here:

[Bug]: Error: turbo.createProject is not supported by the wasm bindings. #27937 (comment)

Maybe I should add a line to the postinst script print message that explains that is necessary.

However, that is also necessary for other things in Termux and also often on Desktop Linux as well, such as for example C# programs like jellyfin-server, and those don't have postinst messages explaining this - they just assume the users will know that. I'm not sure what option is best.

Yes, I know this, but I mean that after restarting Termux, it still seems to require me to manually source it.

robertkirkman · 2026-04-05T05:13:40Z

Yes, I know this, but I mean that after restarting Termux, it still seems to require me to manually source it.

It is because you are using fish instead of bash or zsh. I noticed that when fish is set as the Termux shell with chsh -s fish, it does not get the NEXT_TEST_* variables, but if chsh -s bash or chsh -s zsh is used instead, it works.

If we consider bash and zsh as the best-polished shells in Termux currently (ignoring issues like #25970, #25984, #28433, #28433, and #25264), and consider fish as an outlier, this would imply a problem specific to fish that should be considered separately.

robertkirkman · 2026-04-05T05:18:35Z

This is the issues that i added those harcoded cert file location from Termux, in this image I have used artifect from build, and the reason about adding the env was that, because in one feature of nextjs you can use your corporate companies SSL cert which is provided by your company, so i thought I could make a env which people or user can point to and that will be added to know cert list.

ok actually yes I can reproduce those errors, but I did not know if those were what is fixed by that patch, yes that points out that this PR currently doesn't handle that correctly. I need to change this PR until it works fully. Thank you for confirming those errors get fixed by the patch, now I can check that to see when my version is working.

TomJo2000 · 2026-04-05T20:59:47Z

-	local ENV_PREFIX=$(echo "$RUST_TARGET" | tr '[:lower:]-' '[:upper:]_')
-	if [ "$TERMUX_ARCH" == "aarch64" ]; then
-		export RUSTFLAGS="$RUSTFLAGS -Zshare-generics=y -Csymbol-mangling-version=v0"
+	local ENV_PREFIX=$(echo "$CARGO_TARGET_NAME" | tr '[:lower:]-' '[:upper:]_')


declare/local has a -u flag for this.

Suggested change

local ENV_PREFIX=$(echo "$CARGO_TARGET_NAME" | tr '[:lower:]-' '[:upper:]_')

local -u env_host="${CARGO_TARGET_NAME//-/_}"

https://man.archlinux.org/man/bash.1#u~3

This is also used in the fish build, it probably makes sense to use the same variable name as well..

termux-packages/packages/fish/build.sh

Line 35 in c9ef649

local -u env_host="${CARGO_TARGET_NAME//-/_}"

TomJo2000 · 2026-04-05T21:06:57Z

 	else
 		export "CARGO_TARGET_${ENV_PREFIX}_LINKER"="$CC"
-		export "CC_${RUST_TARGET//-/_}"="$CC"
+		export "CC_${CARGO_TARGET_NAME//-/_}"="$CC"


Suggested change

export "CC_${CARGO_TARGET_NAME//-/_}"="$CC"

export "CC_${env_host}"="$CC"

TomJo2000 · 2026-04-05T21:07:30Z

+termux_step_make() {
 	cd packages/next-swc
-	npx pnpm run build-native-release --target "$RUST_TARGET"
+	npx pnpm run build-native-release --target "$CARGO_TARGET_NAME"


Suggested change

npx pnpm run build-native-release --target "$CARGO_TARGET_NAME"

npx pnpm run build-native-release --target "${env_host}"

This line does not need to be changed because it uses $CARGO_TARGET_NAME unmodified

robertkirkman requested review from Grimler91 and TomJo2000 as code owners April 4, 2026 23:33

robertkirkman force-pushed the turbopack-changes branch from a48a4d5 to 661ff2b Compare April 4, 2026 23:37

robertkirkman force-pushed the turbopack-changes branch from 661ff2b to 0b9f52e Compare April 4, 2026 23:41

robertkirkman commented Apr 5, 2026

View reviewed changes

robertkirkman marked this pull request as draft April 5, 2026 05:15

TomJo2000 reviewed Apr 5, 2026

View reviewed changes

	local ENV_PREFIX=$(echo "$CARGO_TARGET_NAME" \| tr '[:lower:]-' '[:upper:]_')
	local -u env_host="${CARGO_TARGET_NAME//-/_}"

	export "CC_${CARGO_TARGET_NAME//-/_}"="$CC"
	export "CC_${env_host}"="$CC"

	npx pnpm run build-native-release --target "$CARGO_TARGET_NAME"
	npx pnpm run build-native-release --target "${env_host}"

Uh oh!

Conversation

robertkirkman commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robertkirkman commented Apr 5, 2026

Uh oh!

robertkirkman Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

xingguangcuican6666 commented Apr 5, 2026

Uh oh!

xingguangcuican6666 commented Apr 5, 2026

Uh oh!

robertkirkman commented Apr 5, 2026

Uh oh!

Kuldeep-Dilliwar commented Apr 5, 2026

Uh oh!

xingguangcuican6666 commented Apr 5, 2026

Uh oh!

robertkirkman commented Apr 5, 2026

Uh oh!

robertkirkman commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomJo2000 Apr 5, 2026

Choose a reason for hiding this comment

https://man.archlinux.org/man/bash.1#u~3

Uh oh!

TomJo2000 Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

TomJo2000 Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

robertkirkman Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

robertkirkman commented Apr 4, 2026 •

edited

Loading

robertkirkman commented Apr 5, 2026 •

edited

Loading